Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2849713004: Build address_data_test.cc on iOS. (Closed)

Created:
3 years, 7 months ago by sdefresne
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Build address_data_test.cc on iOS. The test has been converted upstream to use ASSERT_DEATH_IF_SUPPORTED and can now be built on iOS. BUG=595645 Review-Url: https://codereview.chromium.org/2849713004 Cr-Commit-Position: refs/heads/master@{#467973} Committed: https://chromium.googlesource.com/chromium/src/+/d2b5298ca0fa264256075ad68eb484ffb51a2fd6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M third_party/libaddressinput/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
sdefresne
Please take a look and send to CQ if LGTY.
3 years, 7 months ago (2017-04-28 09:37:13 UTC) #3
please use gerrit instead
lgtm
3 years, 7 months ago (2017-04-28 13:05:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849713004/1
3 years, 7 months ago (2017-04-28 13:05:45 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 13:09:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d2b5298ca0fa264256075ad68eb4...

Powered by Google App Engine
This is Rietveld 408576698