Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/libaddressinput/BUILD.gn

Issue 2849713004: Build address_data_test.cc on iOS. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libaddressinput/BUILD.gn
diff --git a/third_party/libaddressinput/BUILD.gn b/third_party/libaddressinput/BUILD.gn
index 2ef85fbfd657ef65452732fe364023da7c30826e..80005ffffe306e35420d16b2c3d7d54ff981b223 100644
--- a/third_party/libaddressinput/BUILD.gn
+++ b/third_party/libaddressinput/BUILD.gn
@@ -216,12 +216,6 @@ test("libaddressinput_unittests") {
"src/cpp/test/validation_task_test.cc",
]
- if (is_ios) {
- # TODO(rouslan): This tests uses ASSERT_DEATH which is not supported on
- # iOS. Re-enable once http://crbug.com/595645 is fixed.
- sources -= [ "src/cpp/test/address_data_test.cc" ]
- }
-
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [
":internal_config",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698