Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 2849713002: Remove one layer of abstraction from HTTP/2 frame representations. (Closed)

Created:
3 years, 7 months ago by Bence
Modified:
3 years, 7 months ago
Reviewers:
yasong, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove one layer of abstraction from HTTP/2 frame representations. SpdyFrameWithStreamIdIR was always kind of pointless. This CL lands server change 153630764 by birenroy. BUG=488484 Review-Url: https://codereview.chromium.org/2849713002 Cr-Commit-Position: refs/heads/master@{#468059} Committed: https://chromium.googlesource.com/chromium/src/+/7db35ca75835cb72e0338b130f3a81cc445efa11

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -45 lines) Patch
M net/spdy/core/spdy_framer_test.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M net/spdy/core/spdy_protocol.h View 7 chunks +13 lines, -32 lines 0 comments Download
M net/spdy/core/spdy_protocol.cc View 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Bence
yasong: PTAL. Thank you.
3 years, 7 months ago (2017-04-28 16:12:13 UTC) #6
yasong
On 2017/04/28 16:12:13, Bence wrote: > yasong: PTAL. Thank you. LGTM.
3 years, 7 months ago (2017-04-28 16:22:23 UTC) #7
Bence
xunjieli: please rubber stamp. yasong: thank you for the review.
3 years, 7 months ago (2017-04-28 16:25:35 UTC) #9
xunjieli
On 2017/04/28 16:25:35, Bence wrote: > xunjieli: please rubber stamp. > yasong: thank you for ...
3 years, 7 months ago (2017-04-28 16:44:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849713002/1
3 years, 7 months ago (2017-04-28 17:56:10 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 18:10:22 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7db35ca75835cb72e0338b130f3a...

Powered by Google App Engine
This is Rietveld 408576698