Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Unified Diff: net/spdy/core/spdy_framer_test.cc

Issue 2849713002: Remove one layer of abstraction from HTTP/2 frame representations. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/spdy/core/spdy_protocol.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/core/spdy_framer_test.cc
diff --git a/net/spdy/core/spdy_framer_test.cc b/net/spdy/core/spdy_framer_test.cc
index 66a535459d011a46164b8b9882c4b5d5988696b4..b9bed41dac6660a6aea4efeddfcb81be434638ab 100644
--- a/net/spdy/core/spdy_framer_test.cc
+++ b/net/spdy/core/spdy_framer_test.cc
@@ -396,7 +396,6 @@ class TestSpdyVisitor : public SpdyFramerVisitorInterface,
continuation_count_(0),
altsvc_count_(0),
priority_count_(0),
- test_altsvc_ir_(0),
on_unknown_frame_result_(false),
last_window_update_stream_(0),
last_window_update_delta_(0),
@@ -551,12 +550,12 @@ class TestSpdyVisitor : public SpdyFramerVisitorInterface,
altsvc_vector) override {
VLOG(1) << "OnAltSvc(" << stream_id << ", \"" << origin
<< "\", altsvc_vector)";
- test_altsvc_ir_.set_stream_id(stream_id);
+ test_altsvc_ir_ = SpdyMakeUnique<SpdyAltSvcIR>(stream_id);
if (origin.length() > 0) {
- test_altsvc_ir_.set_origin(SpdyString(origin));
+ test_altsvc_ir_->set_origin(SpdyString(origin));
}
for (const auto& altsvc : altsvc_vector) {
- test_altsvc_ir_.add_altsvc(altsvc);
+ test_altsvc_ir_->add_altsvc(altsvc);
}
++altsvc_count_;
}
@@ -664,7 +663,7 @@ class TestSpdyVisitor : public SpdyFramerVisitorInterface,
int continuation_count_;
int altsvc_count_;
int priority_count_;
- SpdyAltSvcIR test_altsvc_ir_;
+ std::unique_ptr<SpdyAltSvcIR> test_altsvc_ir_;
bool on_unknown_frame_result_;
SpdyStreamId last_window_update_stream_;
int last_window_update_delta_;
@@ -4493,9 +4492,10 @@ TEST_P(SpdyFramerTest, ReadChunkedAltSvcFrame) {
}
EXPECT_EQ(0, visitor.error_count_);
EXPECT_EQ(1, visitor.altsvc_count_);
- ASSERT_EQ(2u, visitor.test_altsvc_ir_.altsvc_vector().size());
- EXPECT_TRUE(visitor.test_altsvc_ir_.altsvc_vector()[0] == altsvc1);
- EXPECT_TRUE(visitor.test_altsvc_ir_.altsvc_vector()[1] == altsvc2);
+ ASSERT_NE(nullptr, visitor.test_altsvc_ir_);
+ ASSERT_EQ(2u, visitor.test_altsvc_ir_->altsvc_vector().size());
+ EXPECT_TRUE(visitor.test_altsvc_ir_->altsvc_vector()[0] == altsvc1);
+ EXPECT_TRUE(visitor.test_altsvc_ir_->altsvc_vector()[1] == altsvc2);
}
// While RFC7838 Section 4 says that an ALTSVC frame on stream 0 with empty
« no previous file with comments | « no previous file | net/spdy/core/spdy_protocol.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698