Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 2849683002: Merge "cros: Update migration banner on login" (Closed)

Created:
3 years, 7 months ago by xiyuan
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Merge "cros: Update migration banner on login" > For all screens: > - Banner content div fit to text content with max-width 722px. > This makes the banner fit text better and gets rid of excessive > left/right padding when text is short; > - Remove font-size override and use inherited 14px from body; > > For login screen (where banner is only used for migration message): > - Reduce 4px of banner-pod space (16px between banner bottom and > the selected user pod with this CL); > - Add 4px left/right padding (24px instead of 20px with the CL); > > BUG=715706 > > Review-Url: https://codereview.chromium.org/2849583002 > Cr-Commit-Position: refs/heads/master@{#467758} > (cherry picked from commit ae63c3b97ae7dae1bd784a05e64be5d4393d74d3) Review-Url: https://codereview.chromium.org/2849683002 . Cr-Commit-Position: refs/branch-heads/3071@{#271} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/cd598e6abbca621ff70974844e6d2f06e76ed65a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M ui/login/account_picker/screen_account_picker.css View 3 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
xiyuan
3 years, 7 months ago (2017-04-27 21:44:34 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cd598e6abbca621ff70974844e6d2f06e76ed65a.

Powered by Google App Engine
This is Rietveld 408576698