Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2849583002: cros: Update migration banner on login (Closed)

Created:
3 years, 7 months ago by xiyuan
Modified:
3 years, 7 months ago
Reviewers:
jdufault
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Update migration banner on login For all screens: - Banner content div fit to text content with max-width 722px. This makes the banner fit text better and gets rid of excessive left/right padding when text is short; - Remove font-size override and use inherited 14px from body; For login screen (where banner is only used for migration message): - Reduce 4px of banner-pod space (16px between banner bottom and the selected user pod with this CL); - Add 4px left/right padding (24px instead of 20px with the CL); BUG=715706 Review-Url: https://codereview.chromium.org/2849583002 Cr-Commit-Position: refs/heads/master@{#467758} Committed: https://chromium.googlesource.com/chromium/src/+/ae63c3b97ae7dae1bd784a05e64be5d4393d74d3

Patch Set 1 #

Patch Set 2 : font-size -> 14px, no override #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M ui/login/account_picker/screen_account_picker.css View 1 3 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
xiyuan
jdufault@, could you help to reviews this? Cosmetic change per UX. Thanks.
3 years, 7 months ago (2017-04-27 18:29:37 UTC) #5
jdufault
lgtm, thanks
3 years, 7 months ago (2017-04-27 18:42:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849583002/40001
3 years, 7 months ago (2017-04-27 19:14:47 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 19:39:54 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ae63c3b97ae7dae1bd784a05e64b...

Powered by Google App Engine
This is Rietveld 408576698