[MD settings] replace secondary-action with separator

[MD settings] replace secondary-action with separator

This CL replaces the use of the .secondary-action class with the
.separator class. This simplifies the row separators allowing for more
custom styling of the secondary actions.

BUG=714320
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2849663002
Cr-Commit-Position: refs/heads/master@{#468528}
Committed: https://chromium.googlesource.com/chromium/src/+/3e51eab19200adc5c174f8a792cb917a9e2a4e13

[dschuyler, 2017-04-27 21:20:38]

Description was changed from

==========
[MD settings] replace secondary-action with separator

This CL replaces the use of the .secondary-action class with the
.separator class. This simplifies the row separators allowing for more
custom styling of the secondary actions.

BUG=714320
==========

to

==========
[MD settings] replace secondary-action with separator

This CL replaces the use of the .secondary-action class with the
.separator class. This simplifies the row separators allowing for more
custom styling of the secondary actions.

BUG=714320
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-04-27 21:20:41]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 21:21:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-04-27 21:22:08]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 21:22:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 01:36:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 01:36:08]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2017-04-28 18:30:12]

dschuyler@chromium.org changed reviewers:
+ hcarmona@chromium.org

[hcarmona, 2017-05-01 18:12:30]

https://codereview.chromium.org/2849663002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/search_page/search_page.html (right):

https://codereview.chromium.org/2849663002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/search_page/search_page.html:91: <div
class="layout horizontal center"
Why don't other sections need these changes?

[dschuyler, 2017-05-01 19:12:08]

https://codereview.chromium.org/2849663002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/search_page/search_page.html (right):

https://codereview.chromium.org/2849663002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/search_page/search_page.html:91: <div
class="layout horizontal center"
On 2017/05/01 18:12:30, hcarmona wrote:
> Why don't other sections need these changes?

This is here for the sake of making a group to hide/show with the hidden$=
attribute. I would like to remove the dependency here and elsewhere on the
layout... classes. I'll look at that as another CL.

[hcarmona, 2017-05-01 19:23:34]

lgtm

[dschuyler, 2017-05-02 00:08:59]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 00:10:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-05-02 00:13:55]

Merged with master

[commit-bot: I haz the power, 2017-05-02 01:22:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 01:22:04]

Dry run: This issue passed the CQ dry run.

[hcarmona, 2017-05-02 01:25:25]

On 2017/05/02 00:13:55, dschuyler wrote:
> Merged with master

Still LGTM

[dschuyler, 2017-05-02 01:28:37]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2017-05-02 01:29:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 01:35:10]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493688517761380,
"parent_rev": "57278545b2bb8e4d6b5ca3d241852bc346933d4e", "commit_rev":
"3e51eab19200adc5c174f8a792cb917a9e2a4e13"}

[commit-bot: I haz the power, 2017-05-02 01:35:20]

Description was changed from

==========
[MD settings] replace secondary-action with separator

This CL replaces the use of the .secondary-action class with the
.separator class. This simplifies the row separators allowing for more
custom styling of the secondary actions.

BUG=714320
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] replace secondary-action with separator

This CL replaces the use of the .secondary-action class with the
.separator class. This simplifies the row separators allowing for more
custom styling of the secondary actions.

BUG=714320
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2849663002
Cr-Commit-Position: refs/heads/master@{#468528}
Committed:
https://chromium.googlesource.com/chromium/src/+/3e51eab19200adc5c174f8a792cb...
==========

[commit-bot: I haz the power, 2017-05-02 01:35:21]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3e51eab19200adc5c174f8a792cb...