Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6037)

Unified Diff: chrome/browser/resources/settings/settings_shared_css.html

Issue 2849663002: [MD settings] replace secondary-action with separator (Closed)
Patch Set: merge with master Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_shared_css.html
diff --git a/chrome/browser/resources/settings/settings_shared_css.html b/chrome/browser/resources/settings/settings_shared_css.html
index 646d17bce8db5fd4d4ed9e282f1df0ee6090e681..f80a70d076c497d5241f99bf7be66ba89c2f9556 100644
--- a/chrome/browser/resources/settings/settings_shared_css.html
+++ b/chrome/browser/resources/settings/settings_shared_css.html
@@ -320,29 +320,6 @@
outline: none;
}
- /* TODO(dschuyler): replace with .separator.
- * The secondary-action wraps a clickable sub-area of a .settings-box.
- * Here is an example with and without a secondary action box:
- *
- * +-------------------------------------------------------+
- * | Main action area .settings-box | .secondary-action |
- * +-------------------------------------------------------+
- * | Another setting-box without a secondary-action |
- * +-------------------------------------------------------+ */
- :-webkit-any(.settings-box, .list-item) .secondary-action {
- -webkit-border-start: var(--settings-separator-line);
- -webkit-margin-start: 20px;
- -webkit-padding-start: 20px;
- align-items: center;
- display: flex;
- flex-shrink: 0;
- height: 36px;
- }
-
- :-webkit-any(.settings-box, .list-item).two-line .secondary-action {
- height: 46px;
- }
-
/* Helper for a list frame to automatically avoid the separator line. */
.vertical-list > *:not(:first-of-type) {
border-top: var(--settings-separator-line);

Powered by Google App Engine
This is Rietveld 408576698