Data savings on overflow menu should use most recent data collection start date

Data savings on overflow menu should use most recent data collection start date

Data savings on the overflow menu should show the date Data Saver was
first turned on or last reset if that date is more recent than 30 days ago. 
The icon color should also be reset when Data Saver is re-enabled.

BUG=716491, 715803
Review-Url: https://codereview.chromium.org/2849563004
Cr-Commit-Position: refs/heads/master@{#468202}
Committed: https://chromium.googlesource.com/chromium/src/+/86ca67f5423cdb1e2ef6f193e2eebdb0abf83ab0

[megjablon, 2017-04-28 23:08:16]

megjablon@chromium.org changed reviewers:
+ mariakhomenko@chromium.org

[megjablon, 2017-04-28 23:08:17]

PTAL, thanks!

[megjablon, 2017-04-28 23:12:57]

Description was changed from

==========
Data savings on overflow menu should use most recent data collection start date

Data savings on the overflow menu should show the date Data Saver was
first turned on or last reset if that date is more recent than 30 days ago.

BUG=716491
==========

to

==========
Data savings on overflow menu should use most recent data collection start date

Data savings on the overflow menu should show the date Data Saver was
first turned on or last reset if that date is more recent than 30 days ago. The
icon color should also be reset when Data Saver is re-enabled.

BUG=716491, 715803
==========

[megjablon, 2017-04-28 23:13:01]

megjablon@chromium.org changed reviewers:
- mariakhomenko@chromium.org

[megjablon, 2017-04-28 23:13:20]

megjablon@chromium.org changed reviewers:
+ miguelg@chromium.org

[megjablon, 2017-04-28 23:13:32]

Description was changed from

==========
Data savings on overflow menu should use most recent data collection start date

Data savings on the overflow menu should show the date Data Saver was
first turned on or last reset if that date is more recent than 30 days ago. The
icon color should also be reset when Data Saver is re-enabled.

BUG=716491, 715803
==========

to

==========
Data savings on overflow menu should use most recent data collection start date

Data savings on the overflow menu should show the date Data Saver was
first turned on or last reset if that date is more recent than 30 days ago. 
The icon color should also be reset when Data Saver is re-enabled.

BUG=716491, 715803
==========

[Maria, 2017-04-28 23:54:10]

On 2017/04/28 23:08:17, megjablon wrote:
> PTAL, thanks!

The description for this change talks about resetting the date to be correct in
case data is cleared, but the implementation in the change resets the icon to
blue. Is one of the changes missing?

[Maria, 2017-04-28 23:54:17]

mariakhomenko@chromium.org changed reviewers:
+ mariakhomenko@chromium.org

[megjablon, 2017-04-28 23:57:43]

Patchset #3 (id:40001) has been deleted

[megjablon, 2017-04-29 00:02:35]

On 2017/04/28 23:54:10, Maria (OOO till May 8) wrote:
> On 2017/04/28 23:08:17, megjablon wrote:
> > PTAL, thanks!
> 
> The description for this change talks about resetting the date to be correct
in
> case data is cleared, but the implementation in the change resets the icon to
> blue. Is one of the changes missing?

Whoops that was an upstream branch issue so one of the changes didn't show in
the diff. Fixed.

[Maria, 2017-04-29 00:11:54]

lgtm

[megjablon, 2017-04-29 00:12:03]

The CQ bit was checked by megjablon@chromium.org

[commit-bot: I haz the power, 2017-04-29 00:12:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 01:06:45]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493424723208030,
"parent_rev": "b1bd0bcdbc0dfdad20497af59e0fb5f3bb99f789", "commit_rev":
"86ca67f5423cdb1e2ef6f193e2eebdb0abf83ab0"}

[commit-bot: I haz the power, 2017-04-29 01:06:54]

Description was changed from

==========
Data savings on overflow menu should use most recent data collection start date

Data savings on the overflow menu should show the date Data Saver was
first turned on or last reset if that date is more recent than 30 days ago. 
The icon color should also be reset when Data Saver is re-enabled.

BUG=716491, 715803
==========

to

==========
Data savings on overflow menu should use most recent data collection start date

Data savings on the overflow menu should show the date Data Saver was
first turned on or last reset if that date is more recent than 30 days ago. 
The icon color should also be reset when Data Saver is re-enabled.

BUG=716491, 715803

Review-Url: https://codereview.chromium.org/2849563004
Cr-Commit-Position: refs/heads/master@{#468202}
Committed:
https://chromium.googlesource.com/chromium/src/+/86ca67f5423cdb1e2ef6f193e2ee...
==========

[commit-bot: I haz the power, 2017-04-29 01:06:54]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/86ca67f5423cdb1e2ef6f193e2ee...