Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4779)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java

Issue 2849563004: Data savings on overflow menu should use most recent data collection start date (Closed)
Patch Set: fix branches Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionMainMenuFooter.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java b/chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java
index 233abced4232953af408f2cf0b1369546f1e847a..cb415ee6ad6b023c6e860475ecfe1e6754714899 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java
@@ -68,6 +68,8 @@ public class DataReductionProxySettings {
private static final String DATA_REDUCTION_HAS_EVER_BEEN_ENABLED_PREF =
"BANDWIDTH_REDUCTION_PROXY_HAS_EVER_BEEN_ENABLED";
+ public static final String DATA_REDUCTION_FIRST_ENABLED_TIME =
+ "BANDWIDTH_REDUCTION_FIRST_ENABLED_TIME";
private static final String PARAM_PERSISTENT_MENU_ITEM_ENABLED = "persistent_menu_item_enabled";
@@ -155,6 +157,15 @@ public class DataReductionProxySettings {
* data reduction statistics if this is the first time the SPDY proxy has been enabled.
*/
public void setDataReductionProxyEnabled(Context context, boolean enabled) {
+ if (enabled
+ && ContextUtils.getAppSharedPreferences().getLong(
+ DATA_REDUCTION_FIRST_ENABLED_TIME, 0)
+ == 0) {
+ ContextUtils.getAppSharedPreferences()
+ .edit()
+ .putLong(DATA_REDUCTION_FIRST_ENABLED_TIME, System.currentTimeMillis())
+ .apply();
+ }
ContextUtils.getAppSharedPreferences().edit()
.putBoolean(DATA_REDUCTION_ENABLED_PREF, enabled).apply();
nativeSetDataReductionProxyEnabled(mNativeDataReductionProxySettings, enabled);
@@ -203,12 +214,25 @@ public class DataReductionProxySettings {
}
/**
+ * Returns the time that the proxy was first enabled. If data saving statistics are cleared,
+ * this is set to the reset time.
+ * @return The time that the proxy was first enabled in milliseconds since the epoch.
+ */
+ public long getDataReductionProxyFirstEnabledTime() {
+ return ContextUtils.getAppSharedPreferences().getLong(DATA_REDUCTION_FIRST_ENABLED_TIME, 0);
+ }
+
+ /**
* Clears all data saving statistics.
*/
public void clearDataSavingStatistics() {
// When the data saving statistics are cleared, reset the snackbar promo that tells the user
// how much data they have saved using Data Saver so far.
DataReductionPromoUtils.saveSnackbarPromoDisplayed(0);
+ ContextUtils.getAppSharedPreferences()
+ .edit()
+ .putLong(DATA_REDUCTION_FIRST_ENABLED_TIME, System.currentTimeMillis())
+ .apply();
nativeClearDataSavingStatistics(mNativeDataReductionProxySettings);
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionMainMenuFooter.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698