[wasm] Implement Generic S128 Load/Store, logical ops and Horizontal add

[wasm] Implement Generic S128 Load/Store, logical ops and Horizontal add
 - Ops: S128Load, S128Store, S128And, S128Or, S128Xor, S128Not, I32x4AddHoriz, I16x8AddHoriz
 - Add x64 assembler support for - phaddd, phaddw, pand, por
 - Enable tests for Globals, other tests applicable to x64 apart from tests for implemented ops

BUG=v8:6020
R=bbudge@chromium.org, bmeurer@chromium.org, zvi.rackover@intel.com

Review-Url: https://codereview.chromium.org/2849463003
Cr-Commit-Position: refs/heads/master@{#45005}
Committed: https://chromium.googlesource.com/v8/v8/+/4a604f2ffe81d1a32fa31f9be3f39a68d57eadb5

[gdeepti, 2017-04-27 06:44:15]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 06:44:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 06:48:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 06:48:53]

Dry run: Try jobs failed on following builders:
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[gdeepti, 2017-04-27 06:52:09]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 06:52:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 07:20:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 07:20:19]

Dry run: This issue passed the CQ dry run.

[zvi, 2017-04-27 15:29:14]

The x86 part LGTM with a minor comment

https://codereview.chromium.org/2849463003/diff/20001/src/compiler/x64/code-g...
File src/compiler/x64/code-generator-x64.cc (right):

https://codereview.chromium.org/2849463003/diff/20001/src/compiler/x64/code-g...
src/compiler/x64/code-generator-x64.cc:2450: __ pxor(dst, dst);
You can probably do without this XOR as starting from Sandybridge, the processor
recognizes the all-one idiom and breaks dependencies on earlier defs to the
register.

Here is what the Optimization Reference Manual has to say:
There is another dependency breaking idiom - the "ones idiom".
• CMPEQ XMM1, XMM1; "ones idiom" set all elements to all "ones"
In this case, the micro-op must execute, however, since it is known that
regardless of the input data the
output data is always "all ones" the micro-op dependency upon its sources does
not exist as with the zero
idiom and it can execute as soon as it finds a free execution port.

[gdeepti, 2017-04-27 16:11:39]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 16:11:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gdeepti, 2017-04-27 16:30:39]

https://codereview.chromium.org/2849463003/diff/20001/src/compiler/x64/code-g...
File src/compiler/x64/code-generator-x64.cc (right):

https://codereview.chromium.org/2849463003/diff/20001/src/compiler/x64/code-g...
src/compiler/x64/code-generator-x64.cc:2450: __ pxor(dst, dst);
On 2017/04/27 15:29:14, zvi wrote:
> You can probably do without this XOR as starting from Sandybridge, the
processor
> recognizes the all-one idiom and breaks dependencies on earlier defs to the
> register.
> 
> Here is what the Optimization Reference Manual has to say:
> There is another dependency breaking idiom - the "ones idiom".
> • CMPEQ XMM1, XMM1; "ones idiom" set all elements to all "ones"
> In this case, the micro-op must execute, however, since it is known that
> regardless of the input data the
> output data is always "all ones" the micro-op dependency upon its sources does
> not exist as with the zero
> idiom and it can execute as soon as it finds a free execution port.

Removed xor, thanks for the pointer to the Optimization Reference Manual.

[commit-bot: I haz the power, 2017-04-27 16:43:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 16:43:44]

Dry run: This issue passed the CQ dry run.

[bbudge, 2017-04-27 17:21:34]

lgtm

[gdeepti, 2017-04-28 18:16:29]

Ping bmeurer@ for OWNERS in src/compiler

[gdeepti, 2017-05-01 16:51:06]

gdeepti@chromium.org changed reviewers:
+ mtrofin@chromium.org

[gdeepti, 2017-05-01 16:51:06]

+mtrofin@ for Owners in src/compiler

[Mircea Trofin, 2017-05-01 23:19:22]

On 2017/05/01 16:51:06, gdeepti wrote:
> +mtrofin@ for Owners in src/compiler

Lgtm

[gdeepti, 2017-05-01 23:24:34]

The CQ bit was checked by gdeepti@chromium.org

[gdeepti, 2017-05-01 23:24:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
zvi.rackover@intel.com
Link to the patchset: https://codereview.chromium.org/2849463003/#ps40001
(title: "Zvi's review")

[commit-bot: I haz the power, 2017-05-01 23:24:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 00:05:54]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493681074498040,
"parent_rev": "cda2e2dd91da6e70505d2e314454d3b66c0bb3a6", "commit_rev":
"4a604f2ffe81d1a32fa31f9be3f39a68d57eadb5"}

[commit-bot: I haz the power, 2017-05-02 00:06:01]

Description was changed from

==========
[wasm] Implement Generic S128 Load/Store, logical ops and Horizontal add
 - Ops: S128Load, S128Store, S128And, S128Or, S128Xor, S128Not, I32x4AddHoriz,
I16x8AddHoriz
 - Add x64 assembler support for - phaddd, phaddw, pand, por
 - Enable tests for Globals, other tests applicable to x64 apart from tests for
implemented ops

BUG=v8:6020

R=bbudge@chromium.org, bmeurer@chromium.org, zvi.rackover@intel.com
==========

to

==========
[wasm] Implement Generic S128 Load/Store, logical ops and Horizontal add
 - Ops: S128Load, S128Store, S128And, S128Or, S128Xor, S128Not, I32x4AddHoriz,
I16x8AddHoriz
 - Add x64 assembler support for - phaddd, phaddw, pand, por
 - Enable tests for Globals, other tests applicable to x64 apart from tests for
implemented ops

BUG=v8:6020

R=bbudge@chromium.org, bmeurer@chromium.org, zvi.rackover@intel.com

Review-Url: https://codereview.chromium.org/2849463003
Cr-Commit-Position: refs/heads/master@{#45005}
Committed:
https://chromium.googlesource.com/v8/v8/+/4a604f2ffe81d1a32fa31f9be3f39a68d57...
==========

[commit-bot: I haz the power, 2017-05-02 00:06:02]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/4a604f2ffe81d1a32fa31f9be3f39a68d57...