Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2849423002: Use ScopedTaskEnvironment instead of MessageLoopForUI in ui/aura/test/. (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
robliao, gab, jam, sky
CC:
chromium-reviews, dfaden+virtualkb_google.com, sadrul, yusukes+watch_chromium.org, nona+watch_chromium.org, tfarina, chfremer+watch_chromium.org, mac-reviews_chromium.org, jbauman+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, shuchen+watch_chromium.org, oka+watchvk_chromium.org, piman+watch_chromium.org, yhanada+watchvk_chromium.org, kalyank, xjz+watch_chromium.org, James Su, danakj+watch_chromium.org, groby+virtualkb_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ScopedTaskEnvironment instead of MessageLoopForUI in ui/aura/test/. ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and base/task_scheduler/post_task.h within its scope. It should be instantiated in everytest that uses either of these APIs (i.e. no test should instantiate a MessageLoop directly). Motivation for ScopedTaskEnvironment can be found in: https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit TBR=sky@chromium.org BUG=708584 Review-Url: https://codereview.chromium.org/2849423002 Cr-Commit-Position: refs/heads/master@{#468756} Committed: https://chromium.googlesource.com/chromium/src/+/1c906dc6495ff5c831a19b72a1f8fb265d1eacf6

Patch Set 1 #

Patch Set 2 : add-deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -45 lines) Patch
M content/browser/media/capture/desktop_capture_device_aura_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/test/test_renderer_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/aura/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/test/aura_test_base.h View 3 chunks +3 lines, -2 lines 0 comments Download
M ui/aura/test/aura_test_base.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M ui/aura/test/aura_test_helper.h View 2 chunks +1 line, -5 lines 0 comments Download
M ui/aura/test/aura_test_helper.cc View 2 chunks +1 line, -3 lines 0 comments Download
M ui/keyboard/keyboard_controller_unittest.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M ui/snapshot/snapshot_aura_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/test/scoped_views_test_helper.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ui/views/test/views_test_helper.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ui/views/test/views_test_helper_aura.h View 1 chunk +1 line, -6 lines 0 comments Download
M ui/views/test/views_test_helper_aura.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M ui/views/test/views_test_helper_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 22 (16 generated)
fdoray
gab@ or robliao@: PTAL This is a prerequisite to migrate v8 from WorkerPool to TaskScheduler.
3 years, 7 months ago (2017-05-02 17:43:42 UTC) #10
gab
On 2017/05/02 17:43:42, fdoray wrote: > gab@ or robliao@: PTAL > > This is a ...
3 years, 7 months ago (2017-05-02 17:59:12 UTC) #11
fdoray
jam@: Please review changes in content/ sky@: Please review changes in ui/
3 years, 7 months ago (2017-05-02 18:01:02 UTC) #15
jam
On 2017/05/02 18:01:02, fdoray wrote: > jam@: Please review changes in content/ lgtm > > ...
3 years, 7 months ago (2017-05-02 19:58:55 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849423002/20001
3 years, 7 months ago (2017-05-02 20:08:51 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 20:15:56 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1c906dc6495ff5c831a19b72a1f8...

Powered by Google App Engine
This is Rietveld 408576698