Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Unified Diff: ui/keyboard/keyboard_controller_unittest.cc

Issue 2849423002: Use ScopedTaskEnvironment instead of MessageLoopForUI in ui/aura/test/. (Closed)
Patch Set: add-deps Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/aura/test/aura_test_helper.cc ('k') | ui/snapshot/snapshot_aura_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/keyboard/keyboard_controller_unittest.cc
diff --git a/ui/keyboard/keyboard_controller_unittest.cc b/ui/keyboard/keyboard_controller_unittest.cc
index fa58eb457993d71610f976621febdbc55ce426ed..d049168f3d5601c84a7f4caa0e57ca99f2493ae8 100644
--- a/ui/keyboard/keyboard_controller_unittest.cc
+++ b/ui/keyboard/keyboard_controller_unittest.cc
@@ -9,8 +9,8 @@
#include "base/bind.h"
#include "base/command_line.h"
#include "base/macros.h"
-#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
+#include "base/test/scoped_task_environment.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/aura/client/focus_client.h"
#include "ui/aura/layout_manager.h"
@@ -212,7 +212,11 @@ class KeyboardControllerTest : public testing::Test,
public KeyboardControllerObserver {
public:
KeyboardControllerTest()
- : number_of_calls_(0), ui_(nullptr), keyboard_closed_(false) {}
+ : scoped_task_environment_(
+ base::test::ScopedTaskEnvironment::MainThreadType::UI),
+ number_of_calls_(0),
+ ui_(nullptr),
+ keyboard_closed_(false) {}
~KeyboardControllerTest() override {}
void SetUp() override {
@@ -225,7 +229,7 @@ class KeyboardControllerTest : public testing::Test,
&context_factory_private);
ui::SetUpInputMethodFactoryForTesting();
- aura_test_helper_.reset(new aura::test::AuraTestHelper(&message_loop_));
+ aura_test_helper_.reset(new aura::test::AuraTestHelper());
aura_test_helper_->SetUp(context_factory, context_factory_private);
new wm::DefaultActivationClient(aura_test_helper_->root_window());
focus_controller_.reset(new TestFocusController(root_window()));
@@ -302,7 +306,7 @@ class KeyboardControllerTest : public testing::Test,
void ResetController() { controller_.reset(); }
- base::MessageLoopForUI message_loop_;
+ base::test::ScopedTaskEnvironment scoped_task_environment_;
std::unique_ptr<aura::test::AuraTestHelper> aura_test_helper_;
std::unique_ptr<TestFocusController> focus_controller_;
« no previous file with comments | « ui/aura/test/aura_test_helper.cc ('k') | ui/snapshot/snapshot_aura_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698