Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3417)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java

Issue 2849283002: Fix omnibox suggestions being overdrawn with the nav bar. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java
index 531a761ad5ea8c38019454ffd59ccc5fe3fb681a..bbf2c77cb5e52f508ccdf5357587f577ac88e64d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java
@@ -35,6 +35,7 @@ import org.chromium.chrome.R;
import org.chromium.chrome.browser.omnibox.OmniboxResultsAdapter.OmniboxResultItem;
import org.chromium.chrome.browser.omnibox.OmniboxResultsAdapter.OmniboxSuggestionDelegate;
import org.chromium.chrome.browser.omnibox.OmniboxSuggestion.MatchClassification;
+import org.chromium.chrome.browser.util.ViewUtils;
import org.chromium.chrome.browser.widget.TintedDrawable;
import org.chromium.ui.base.DeviceFormFactor;
@@ -862,7 +863,8 @@ class SuggestionView extends ViewGroup {
private int getUrlBarLeftOffset() {
if (mLocationBar.mustQueryUrlBarLocationForSuggestions()) {
- mUrlBar.getLocationInWindow(mViewPositionHolder);
+ View contentView = getRootView().findViewById(android.R.id.content);
+ ViewUtils.getRelativeLayoutPosition(contentView, mUrlBar, mViewPositionHolder);
return mViewPositionHolder[0];
} else {
return ApiCompatibilityUtils.isLayoutRtl(this) ? mPhoneUrlBarLeftOffsetRtlPx
@@ -877,7 +879,8 @@ class SuggestionView extends ViewGroup {
if (mLocationBar == null) return 0;
int leftOffset = getUrlBarLeftOffset();
- getLocationInWindow(mViewPositionHolder);
+ View contentView = getRootView().findViewById(android.R.id.content);
+ ViewUtils.getRelativeLayoutPosition(contentView, this, mViewPositionHolder);
return leftOffset + mUrlBar.getPaddingLeft() - mViewPositionHolder[0];
}
@@ -888,7 +891,8 @@ class SuggestionView extends ViewGroup {
if (mLocationBar == null) return 0;
int leftOffset = getUrlBarLeftOffset();
- getLocationInWindow(mViewPositionHolder);
+ View contentView = getRootView().findViewById(android.R.id.content);
+ ViewUtils.getRelativeLayoutPosition(contentView, this, mViewPositionHolder);
return leftOffset + mUrlBar.getWidth() - mUrlBar.getPaddingRight()
- mViewPositionHolder[0];
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698