Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 2849153003: Update signin confirmation strings on Android and iOS (Closed)

Created:
3 years, 7 months ago by bsazonov
Modified:
3 years, 7 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, agrieve+watch_chromium.org, marq+watch_chromium.org, srahim+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update signin confirmation strings on Android and iOS This CL updates 'Control how this works in Settings' UI strings. BUG=704639 Review-Url: https://codereview.chromium.org/2849153003 Cr-Commit-Position: refs/heads/master@{#468627} Committed: https://chromium.googlesource.com/chromium/src/+/68557831bd0eefa24608e16f7018dc89059a9a09

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/app/strings/ios_strings.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
bsazonov
Bernhard, please review changes in chrome/android/java/strings/android_chrome_strings.grd Mark, please review changes in ios/chrome/app/strings/ios_strings.grd
3 years, 7 months ago (2017-05-02 12:59:23 UTC) #4
Bernhard Bauer
lgtm
3 years, 7 months ago (2017-05-02 13:20:53 UTC) #5
marq (ping after 24h)
lgtm
3 years, 7 months ago (2017-05-02 14:10:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849153003/1
3 years, 7 months ago (2017-05-02 14:13:00 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 14:18:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/68557831bd0eefa24608e16f7018...

Powered by Google App Engine
This is Rietveld 408576698