Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2849153002: Simplify test file used by testBlinkPerfTracingMetricsForMeasureFrameTime & enable it on Android (Closed)

Created:
3 years, 7 months ago by nednguyen
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews, jam, darin-cc_chromium.org, telemetry-reviews_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify test file used by testBlinkPerfTracingMetricsForMeasureFrameTime & enable it on Android This test was failing on Android Nexus 5 device due to the loading taking too long. Simplifying its test case seems to fix the problem. BUG=715685 TBR=wangxianzhu@chromium.org Review-Url: https://codereview.chromium.org/2849153002 Cr-Commit-Position: refs/heads/master@{#468314} Committed: https://chromium.googlesource.com/chromium/src/+/37edd8a0d254bfecf082744086abe31ffb8cc321

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -17 lines) Patch
M third_party/WebKit/PerformanceTests/TestData/color-changes-measure-frame-time.html View 2 chunks +1 line, -15 lines 0 comments Download
M tools/perf/benchmarks/blink_perf_unittest.py View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849153002/20001
3 years, 7 months ago (2017-05-01 13:29:15 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-01 13:29:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849153002/20001
3 years, 7 months ago (2017-05-01 15:18:23 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 15:24:13 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/37edd8a0d254bfecf082744086ab...

Powered by Google App Engine
This is Rietveld 408576698