Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: tools/perf/benchmarks/blink_perf_unittest.py

Issue 2849153002: Simplify test file used by testBlinkPerfTracingMetricsForMeasureFrameTime & enable it on Android (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/PerformanceTests/TestData/color-changes-measure-frame-time.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2017 The Chromium Authors. All rights reserved. 1 # Copyright 2017 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import os 4 import os
5 import unittest 5 import unittest
6 6
7 from telemetry import decorators
8 from telemetry import story 7 from telemetry import story
9 from telemetry.page import page as page_module 8 from telemetry.page import page as page_module
10 from telemetry.testing import options_for_unittests 9 from telemetry.testing import options_for_unittests
11 from telemetry.testing import page_test_test_case 10 from telemetry.testing import page_test_test_case
12 from telemetry.timeline import async_slice 11 from telemetry.timeline import async_slice
13 from telemetry.timeline import model as model_module 12 from telemetry.timeline import model as model_module
14 13
15 14
16 from benchmarks import blink_perf 15 from benchmarks import blink_perf
17 16
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 frame_view_layouts = results.FindAllPageSpecificValuesNamed( 48 frame_view_layouts = results.FindAllPageSpecificValuesNamed(
50 'FrameView::layout') 49 'FrameView::layout')
51 self.assertEquals(len(frame_view_layouts), 1) 50 self.assertEquals(len(frame_view_layouts), 1)
52 self.assertGreater(frame_view_layouts[0].GetRepresentativeNumber, 0.1) 51 self.assertGreater(frame_view_layouts[0].GetRepresentativeNumber, 0.1)
53 52
54 update_layout_trees = results.FindAllPageSpecificValuesNamed( 53 update_layout_trees = results.FindAllPageSpecificValuesNamed(
55 'UpdateLayoutTree') 54 'UpdateLayoutTree')
56 self.assertEquals(len(update_layout_trees), 1) 55 self.assertEquals(len(update_layout_trees), 1)
57 self.assertGreater(update_layout_trees[0].GetRepresentativeNumber, 0.1) 56 self.assertGreater(update_layout_trees[0].GetRepresentativeNumber, 0.1)
58 57
59 @decorators.Disabled('android') # crbug.com/715685
60 def testBlinkPerfTracingMetricsForMeasureFrameTime(self): 58 def testBlinkPerfTracingMetricsForMeasureFrameTime(self):
61 results = self.RunMeasurement(measurement=self._measurement, 59 results = self.RunMeasurement(measurement=self._measurement,
62 ps=self._CreateStorySetForTestFile( 60 ps=self._CreateStorySetForTestFile(
63 'color-changes-measure-frame-time.html'), 61 'color-changes-measure-frame-time.html'),
64 options=self._options) 62 options=self._options)
65 self.assertFalse(results.failures) 63 self.assertFalse(results.failures)
66 self.assertEquals(len(results.FindAllTraceValues()), 1) 64 self.assertEquals(len(results.FindAllTraceValues()), 1)
67 65
68 frame_view_prepaints = results.FindAllPageSpecificValuesNamed( 66 frame_view_prepaints = results.FindAllPageSpecificValuesNamed(
69 'FrameView::prePaint') 67 'FrameView::prePaint')
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 renderer_main.BeginSlice('blink', 'foo', 120) 171 renderer_main.BeginSlice('blink', 'foo', 120)
174 renderer_main.EndSlice(140) 172 renderer_main.EndSlice(140)
175 173
176 renderer_main.BeginSlice('blink', 'bar', 400) 174 renderer_main.BeginSlice('blink', 'bar', 400)
177 renderer_main.EndSlice(420) 175 renderer_main.EndSlice(420)
178 176
179 self.assertEquals( 177 self.assertEquals(
180 blink_perf._ComputeTraceEventsThreadTimeForBlinkPerf( 178 blink_perf._ComputeTraceEventsThreadTimeForBlinkPerf(
181 renderer_main, ['foo', 'bar']), 179 renderer_main, ['foo', 'bar']),
182 {'foo': [20], 'bar': [20]}) 180 {'foo': [20], 'bar': [20]})
OLDNEW
« no previous file with comments | « third_party/WebKit/PerformanceTests/TestData/color-changes-measure-frame-time.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698