webshare: Small refactor of WebShare (OnceCallback, const&, and alias)

webshare: Small refactor of WebShare (OnceCallback, const&, and alias)


1. Uses OnceCallback instead of Callback.
2. Changes the close callback to use a const& to avoid copying the string.
3. Adds an alias for base::OnceCallback<void(const base::Optional<std::string>&)>:
   WebShareTargetPickerCallback.


BUG=716956
Review-Url: https://codereview.chromium.org/2849143002
Cr-Commit-Position: refs/heads/master@{#468498}
Committed: https://chromium.googlesource.com/chromium/src/+/928d141051d4bf9b8ae82a708e914470f5787b54

[ortuno, 2017-05-01 05:44:31]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 05:44:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ortuno, 2017-05-01 06:34:16]

ortuno@chromium.org changed reviewers:
+ mgiuca@chromium.org

[ortuno, 2017-05-01 06:34:17]

mgiuca: PTAL

[ortuno, 2017-05-01 06:43:59]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 06:44:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Matt Giuca, 2017-05-01 06:50:06]

lgtm % nit

Thanks for doing this!

https://codereview.chromium.org/2849143002/diff/20001/chrome/browser/ui/brows...
File chrome/browser/ui/browser_dialogs.h (right):

https://codereview.chromium.org/2849143002/diff/20001/chrome/browser/ui/brows...
chrome/browser/ui/browser_dialogs.h:79: base::Callback<void(const
base::Optional<std::string>&)>;
I think this should go at the bottom of the file -- see how there is a similar
one called IntentPickerResponse. Just make sure it goes outside of the ifdef
CHROMEOS.

[ortuno, 2017-05-01 07:13:02]

Thanks!

https://codereview.chromium.org/2849143002/diff/20001/chrome/browser/ui/brows...
File chrome/browser/ui/browser_dialogs.h (right):

https://codereview.chromium.org/2849143002/diff/20001/chrome/browser/ui/brows...
chrome/browser/ui/browser_dialogs.h:79: base::Callback<void(const
base::Optional<std::string>&)>;
On 2017/05/01 at 06:50:06, Matt Giuca wrote:
> I think this should go at the bottom of the file -- see how there is a similar
one called IntentPickerResponse. Just make sure it goes outside of the ifdef
CHROMEOS.

As discussed the alias has to be defined before it's used i.e. before
ShowWebShareTargetPickerDialog.

[ortuno, 2017-05-01 07:14:35]

ortuno@chromium.org changed reviewers:
+ sky@chromium.org

[ortuno, 2017-05-01 07:14:35]

sky: PTAL at chrome/browser/ui

[commit-bot: I haz the power, 2017-05-01 07:27:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 07:27:48]

Dry run: This issue passed the CQ dry run.

[sky, 2017-05-01 21:08:50]

LGTM

https://codereview.chromium.org/2849143002/diff/20001/chrome/browser/ui/brows...
File chrome/browser/ui/browser_dialogs.h (right):

https://codereview.chromium.org/2849143002/diff/20001/chrome/browser/ui/brows...
chrome/browser/ui/browser_dialogs.h:79: base::Callback<void(const
base::Optional<std::string>&)>;
On 2017/05/01 07:13:02, ortuno wrote:
> On 2017/05/01 at 06:50:06, Matt Giuca wrote:
> > I think this should go at the bottom of the file -- see how there is a
similar
> one called IntentPickerResponse. Just make sure it goes outside of the ifdef
> CHROMEOS.
> 
> As discussed the alias has to be defined before it's used i.e. before
> ShowWebShareTargetPickerDialog.

optional: put this right above the the single place it's used.
optional2: use OnceCallback.

[ortuno, 2017-05-01 22:54:39]

Description was changed from

==========
webshare: Change callback to use const& and add an alias for it

Changes the close callback to use a const& to avoid copying the string.
Also adds an alias for base::Callback<void(const base::Optional<std::string>&)>:
WebShareTargetPickerCallback.

BUG=716956
==========

to

==========
webshare: Small refactor of WebShare (OnceCallback, const&, and alias)


1. Uses OnceCallback instead of Callback.
1, Changes the close callback to use a const& to avoid copying the string.
2. Adds an alias for base::OnceCallback<void(const
base::Optional<std::string>&)>:
   WebShareTargetPickerCallback.


BUG=716956
==========

[ortuno, 2017-05-01 22:55:00]

https://codereview.chromium.org/2849143002/diff/20001/chrome/browser/ui/brows...
File chrome/browser/ui/browser_dialogs.h (right):

https://codereview.chromium.org/2849143002/diff/20001/chrome/browser/ui/brows...
chrome/browser/ui/browser_dialogs.h:79: base::Callback<void(const
base::Optional<std::string>&)>;
On 2017/05/01 at 21:08:50, sky wrote:
> On 2017/05/01 07:13:02, ortuno wrote:
> > On 2017/05/01 at 06:50:06, Matt Giuca wrote:
> > > I think this should go at the bottom of the file -- see how there is a
similar
> > one called IntentPickerResponse. Just make sure it goes outside of the ifdef
> > CHROMEOS.
> > 
> > As discussed the alias has to be defined before it's used i.e. before
> > ShowWebShareTargetPickerDialog.
> 
> optional: put this right above the the single place it's used.

Done. Q: Is it usually just a judgement call where to put the alias? The style
guide says to put it at the top of the file with other types[1] but I've seen
instances of them being defined right above where they are used[2].

> optional2: use OnceCallback.

Done.

[1] https://google.github.io/styleguide/cppguide.html#Declaration_Order
[2]
https://cs.chromium.org/chromium/src/device/bluetooth/bluetooth_device.h?sq=p...

[ortuno, 2017-05-01 22:55:04]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 22:55:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Matt Giuca, 2017-05-01 23:15:33]

s lgtm % nit

https://codereview.chromium.org/2849143002/diff/40001/chrome/browser/ui/brows...
File chrome/browser/ui/browser_dialogs.h (right):

https://codereview.chromium.org/2849143002/diff/40001/chrome/browser/ui/brows...
chrome/browser/ui/browser_dialogs.h:163: base::OnceCallback<void(const
base::Optional<std::string>&)>;
nit: Blank line between.

[ortuno, 2017-05-01 23:18:59]

Description was changed from

==========
webshare: Small refactor of WebShare (OnceCallback, const&, and alias)


1. Uses OnceCallback instead of Callback.
1, Changes the close callback to use a const& to avoid copying the string.
2. Adds an alias for base::OnceCallback<void(const
base::Optional<std::string>&)>:
   WebShareTargetPickerCallback.


BUG=716956
==========

to

==========
webshare: Small refactor of WebShare (OnceCallback, const&, and alias)


1. Uses OnceCallback instead of Callback.
2. Changes the close callback to use a const& to avoid copying the string.
3. Adds an alias for base::OnceCallback<void(const
base::Optional<std::string>&)>:
   WebShareTargetPickerCallback.


BUG=716956
==========

[ortuno, 2017-05-01 23:19:10]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2017-05-01 23:19:10]

Thanks all.

[ortuno, 2017-05-01 23:19:11]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
mgiuca@chromium.org
Link to the patchset: https://codereview.chromium.org/2849143002/#ps60001
(title: "Add new line")

[commit-bot: I haz the power, 2017-05-01 23:19:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 00:09:11]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493680750317320,
"parent_rev": "f027d42fa7e1ce07090bb20494e58b61052ebcc9", "commit_rev":
"928d141051d4bf9b8ae82a708e914470f5787b54"}

[commit-bot: I haz the power, 2017-05-02 00:09:48]

Description was changed from

==========
webshare: Small refactor of WebShare (OnceCallback, const&, and alias)


1. Uses OnceCallback instead of Callback.
2. Changes the close callback to use a const& to avoid copying the string.
3. Adds an alias for base::OnceCallback<void(const
base::Optional<std::string>&)>:
   WebShareTargetPickerCallback.


BUG=716956
==========

to

==========
webshare: Small refactor of WebShare (OnceCallback, const&, and alias)


1. Uses OnceCallback instead of Callback.
2. Changes the close callback to use a const& to avoid copying the string.
3. Adds an alias for base::OnceCallback<void(const
base::Optional<std::string>&)>:
   WebShareTargetPickerCallback.


BUG=716956

Review-Url: https://codereview.chromium.org/2849143002
Cr-Commit-Position: refs/heads/master@{#468498}
Committed:
https://chromium.googlesource.com/chromium/src/+/928d141051d4bf9b8ae82a708e91...
==========

[commit-bot: I haz the power, 2017-05-02 00:09:49]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/928d141051d4bf9b8ae82a708e91...