Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2820)

Unified Diff: chrome/browser/ui/views/webshare/webshare_target_picker_view_unittest.cc

Issue 2849143002: webshare: Small refactor of WebShare (OnceCallback, const&, and alias) (Closed)
Patch Set: Add new line Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/webshare/webshare_target_picker_view_unittest.cc
diff --git a/chrome/browser/ui/views/webshare/webshare_target_picker_view_unittest.cc b/chrome/browser/ui/views/webshare/webshare_target_picker_view_unittest.cc
index dc57d740962c8a7513496f12dc48eae3ec658bde..cb598db1fb62120a720ccdbbfebb5219fb0b957e 100644
--- a/chrome/browser/ui/views/webshare/webshare_target_picker_view_unittest.cc
+++ b/chrome/browser/ui/views/webshare/webshare_target_picker_view_unittest.cc
@@ -61,8 +61,8 @@ class WebShareTargetPickerViewTest : public views::ViewsTestBase {
// Creates the WebShareTargetPickerView (available as view()).
void CreateView(const std::vector<std::pair<base::string16, GURL>>& targets) {
view_ = new WebShareTargetPickerView(
- targets, base::Bind(&WebShareTargetPickerViewTest::OnCallback,
- base::Unretained(this)));
+ targets, base::BindOnce(&WebShareTargetPickerViewTest::OnCallback,
+ base::Unretained(this)));
constrained_window::CreateBrowserModalDialogViews(
view_, parent_widget_->GetNativeWindow())
->Show();
@@ -83,7 +83,7 @@ class WebShareTargetPickerViewTest : public views::ViewsTestBase {
const base::Optional<std::string>& result() { return result_; }
private:
- void OnCallback(base::Optional<std::string> result) {
+ void OnCallback(const base::Optional<std::string>& result) {
result_ = result;
if (quit_closure_)
quit_closure_.Run();
« no previous file with comments | « chrome/browser/ui/views/webshare/webshare_target_picker_view.cc ('k') | chrome/browser/webshare/share_service_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698