Send AndroidOverlay routing token from WMPI to AVDA.

Send AndroidOverlay routing token from WMPI to AVDA.

This CL makes WMPI mirror the CVV surface ID logic with routing
tokens for AndroidOverlay.  The routing token is sent to AVDA, which
does nothing with it.

This CL also splits the existing RequestSurfaceCB into two separate
callbacks.  RequestSurfaceCB remains unchanged, providing a CVV id.
This CL adds Request/Provide OverlayInfoCB to send the CVV id and/or
the routing token.  Most existing instances of R/P SurfaceCB are
now R/P OverlayInfoCB instead, since everything from AVDA up to WMPI
really wants whatever info it needs to create overlays.

BUG=719693
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2849043002
Cr-Commit-Position: refs/heads/master@{#472369}
Committed: https://chromium.googlesource.com/chromium/src/+/2ff93adf7ed746c0e945c250e52b8d30adfbf719

[liberato (no reviews please), 2017-04-29 19:24:48]

Description was changed from

==========
started sending routing token from WMPI

BUG=
==========

to

==========
started sending routing token from WMPI

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[liberato (no reviews please), 2017-05-08 20:46:31]

Description was changed from

==========
started sending routing token from WMPI

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Send AndroidOverlay routing token from WMPI to AVDA.

This CL makes WMPI mirror the CVV surface ID logic with routing
tokens for AndroidOverlay.  The routing token is sent to AVDA, which
does nothing with it.

This CL also splits the existing RequestSurfaceCB into two separate
callbacks.  RequestSurfaceCB remains unchanged, providing a CVV id.
This CL adds Request/Provide OverlayInfoCB to send the CVV id and/or
the routing token.  Most existing instances of R/P SurfaceCB are
now R/P OverlayInfoCB instead, since everything from AVDA up to WMPI
really wants whatever info it needs to create overlays.

BUG=719693
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[liberato (no reviews please), 2017-05-08 20:46:37]

The CQ bit was checked by liberato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 20:47:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[liberato (no reviews please), 2017-05-08 20:48:42]

Description was changed from

==========
Send AndroidOverlay routing token from WMPI to AVDA.

This CL makes WMPI mirror the CVV surface ID logic with routing
tokens for AndroidOverlay.  The routing token is sent to AVDA, which
does nothing with it.

This CL also splits the existing RequestSurfaceCB into two separate
callbacks.  RequestSurfaceCB remains unchanged, providing a CVV id.
This CL adds Request/Provide OverlayInfoCB to send the CVV id and/or
the routing token.  Most existing instances of R/P SurfaceCB are
now R/P OverlayInfoCB instead, since everything from AVDA up to WMPI
really wants whatever info it needs to create overlays.

BUG=719693
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Send AndroidOverlay routing token from WMPI to AVDA.

This CL makes WMPI mirror the CVV surface ID logic with routing
tokens for AndroidOverlay.  The routing token is sent to AVDA, which
does nothing with it.

This CL also splits the existing RequestSurfaceCB into two separate
callbacks.  RequestSurfaceCB remains unchanged, providing a CVV id.
This CL adds Request/Provide OverlayInfoCB to send the CVV id and/or
the routing token.  Most existing instances of R/P SurfaceCB are
now R/P OverlayInfoCB instead, since everything from AVDA up to WMPI
really wants whatever info it needs to create overlays.

BUG=719693
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[liberato (no reviews please), 2017-05-08 20:48:42]

liberato@chromium.org changed reviewers:
+ tguilbert@chromium.org, watk@chromium.org

[liberato (no reviews please), 2017-05-08 20:51:58]

here's a mostly-plumbing CL to get a routing token to AVDA. 

the important, non-plumbing, bit of it is in WMPI, to mirror the CVV surface ID
logic.  the first use-case will be using AndroidOverlay exactly where we use
CVV, so that we're changing one thing at a time.

most of the rest of it is splitting "RequestSurfaceCB" up into "CVV only" or
"CVV or AndroidOverlay".

thanks
-fl

[commit-bot: I haz the power, 2017-05-08 20:52:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 20:52:48]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[liberato (no reviews please), 2017-05-08 20:55:43]

The CQ bit was checked by liberato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 20:56:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 21:13:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 21:13:23]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[liberato (no reviews please), 2017-05-08 21:46:16]

The CQ bit was checked by liberato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 21:47:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 22:00:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 22:00:36]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[liberato (no reviews please), 2017-05-08 22:16:07]

The CQ bit was checked by liberato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 22:17:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 22:46:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 22:46:12]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
  win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[tguilbert, 2017-05-08 23:10:29]

Some nits.

liberato@ do you foresee adding a lot more code into WMPI? My only concern is
that WMPI already has a lot of logic in it.

https://codereview.chromium.org/2849043002/diff/200001/content/renderer/rende...
File content/renderer/render_frame_impl.h (right):

https://codereview.chromium.org/2849043002/diff/200001/content/renderer/rende...
content/renderer/render_frame_impl.h:1149: void
RequestOverlayRoutingToken(media::RoutingTokenCallback callback);
Should this still be passed as a const ref?

https://codereview.chromium.org/2849043002/diff/200001/media/blink/webmediapl...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/2849043002/diff/200001/media/blink/webmediapl...
media/blink/webmediaplayer_impl.cc:358: } else if
(!request_routing_token_cb_.is_null() &&
NIT: can you remove the is_null (and the negation)?

https://codereview.chromium.org/2849043002/diff/200001/media/blink/webmediapl...
media/blink/webmediaplayer_impl.cc:1778: if (provide_overlay_info_cb_.is_null())
NIT: remove is_null and add negation?

https://codereview.chromium.org/2849043002/diff/200001/media/blink/webmediapl...
File media/blink/webmediaplayer_impl.h (right):

https://codereview.chromium.org/2849043002/diff/200001/media/blink/webmediapl...
media/blink/webmediaplayer_impl.h:778: // have no token, which can't be sent via
IPC.
Can you clarify the states in this comment? IIUC,
if has_value, we have one.
if !has_value, we are waiting for one
if has_value and value.is_empty, we never requested the token, and we can't send
it?

NINJA EDIT: I think that the thing that confused me is the 'A null token'. Can
you change it to An empty token?

[liberato (no reviews please), 2017-05-09 16:46:24]

The CQ bit was checked by liberato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 16:47:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[liberato (no reviews please), 2017-05-09 16:55:37]

thanks for the feedback.

WMPI: i don't expect too many more changes, but this definitely is not the last
one either.

in particular, there's another route that we could go with this, that's closer
to the final state we'll want.  i went with the current approach in this CL
because it's a much closer match to the existing (working) logic than the
alternative.

however, this is approximately what we'd do when using android overlay in WMPI
if we went with the alternative approach in place of this CL:

- always request the routing token from RFHI.
- send the routing token to AVDA when it arrives, hopefully in the initial
config.
- send fullscreen enter / exit notifications via callback
- send fullscreen status (is / isn't fullscreen) as part of the initial config.
- if AVDA says that it doesn't support SetSurface, then WMPI would auto-restart
AVDA during a full screen transition, unconditionally (maybe we could be smarter
with an additional callback, or something).

AVDA would have to do approximately this:

- in M+, the video surface chooser would use the full screen signal to decide
overlay / not overlay.
- pre-M, it would use the full screen state in the initial config to decide.

this lets us transition to smarter logic in the chooser for other fullscreen
cases.  it's just a big jump from where it is now.

hrm, now that i write it out, it's really not as bad as i thought.  i'll give
that a try and we can see which one is better.

-fl

https://codereview.chromium.org/2849043002/diff/200001/content/renderer/rende...
File content/renderer/render_frame_impl.h (right):

https://codereview.chromium.org/2849043002/diff/200001/content/renderer/rende...
content/renderer/render_frame_impl.h:1149: void
RequestOverlayRoutingToken(media::RoutingTokenCallback callback);
On 2017/05/08 23:10:28, tguilbert wrote:
> Should this still be passed as a const ref?

const ref is now used when the desired behavior is to copy the callback.  here,
move is fine.

https://codereview.chromium.org/2849043002/diff/200001/media/blink/webmediapl...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/2849043002/diff/200001/media/blink/webmediapl...
media/blink/webmediaplayer_impl.cc:358: } else if
(!request_routing_token_cb_.is_null() &&
On 2017/05/08 23:10:29, tguilbert wrote:
> NIT: can you remove the is_null (and the negation)?

Done.

https://codereview.chromium.org/2849043002/diff/200001/media/blink/webmediapl...
media/blink/webmediaplayer_impl.cc:1778: if (provide_overlay_info_cb_.is_null())
On 2017/05/08 23:10:29, tguilbert wrote:
> NIT: remove is_null and add negation?

Done.

https://codereview.chromium.org/2849043002/diff/200001/media/blink/webmediapl...
File media/blink/webmediaplayer_impl.h (right):

https://codereview.chromium.org/2849043002/diff/200001/media/blink/webmediapl...
media/blink/webmediaplayer_impl.h:778: // have no token, which can't be sent via
IPC.
On 2017/05/08 23:10:29, tguilbert wrote:
> Can you clarify the states in this comment? IIUC,
> if has_value, we have one.
> if !has_value, we are waiting for one
> if has_value and value.is_empty, we never requested the token, and we can't
send
> it?
> 
> NINJA EDIT: I think that the thing that confused me is the 'A null token'. Can
> you change it to An empty token?

s/null/empty/: Done

for has_value && is_empty, we did request a token, but the answer was "no".

[commit-bot: I haz the power, 2017-05-09 16:59:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 16:59:11]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[watk, 2017-05-09 17:26:26]

Sounds like you're going to try another approach? I'll hold off until that one
then.

[liberato (no reviews please), 2017-05-09 17:29:20]

On 2017/05/09 17:26:26, watk wrote:
> Sounds like you're going to try another approach? I'll hold off until that one
> then.

yeah, i am trying a new approach.  when i wrote out the description, it didn't
sound so bad.  sorry about the churn.

-fl

[watk, 2017-05-09 17:30:40]

np at all

On Tue, May 9, 2017 at 10:29 AM, <liberato@chromium.org> wrote:

> On 2017/05/09 17:26:26, watk wrote:
> > Sounds like you're going to try another approach? I'll hold off until
> that one
> > then.
>
> yeah, i am trying a new approach. when i wrote out the description, it
> didn't
> sound so bad. sorry about the churn.
>
> -fl
>
> https://codereview.chromium.org/2849043002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[liberato (no reviews please), 2017-05-11 18:46:14]

The CQ bit was checked by liberato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 18:46:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[liberato (no reviews please), 2017-05-11 18:47:29]

The CQ bit was unchecked by liberato@chromium.org

[liberato (no reviews please), 2017-05-11 18:47:59]

The CQ bit was checked by liberato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 18:49:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[liberato (no reviews please), 2017-05-11 22:12:48]

On 2017/05/09 17:30:40, watk wrote:
> np at all
> 
> On Tue, May 9, 2017 at 10:29 AM, <mailto:liberato@chromium.org> wrote:
> 
> > On 2017/05/09 17:26:26, watk wrote:
> > > Sounds like you're going to try another approach? I'll hold off until
> > that one
> > > then.
> >
> > yeah, i am trying a new approach. when i wrote out the description, it
> > didn't
> > sound so bad. sorry about the churn.
> >
> > -fl
> >
> > https://codereview.chromium.org/2849043002/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

after trying the other approach, it turns out to be the same.

when we make AVDA smarter about deciding when to use an overlay, we can just
call
EnableOverlay() earlier in WMPI.  the decoder could signal if it wants that via
another argument like |decoder_requres_restart_for_overlay|.  so, it's not like
there's much more to add to this one.

so, sorry for about the (now recursive) churn.

-fl

[tguilbert, 2017-05-12 21:11:11]

LGTM

https://codereview.chromium.org/2849043002/diff/300001/media/base/media_switc...
File media/base/media_switches.h (right):

https://codereview.chromium.org/2849043002/diff/300001/media/base/media_switc...
media/base/media_switches.h:118: MEDIA_EXPORT extern const base::Feature
kAndroidMediaPlayerRenderer;
watk@ pointed out that kAndroidMediaPlayerRenderer is no longer used. Can you
remove this, unless watk@ has a CL that already does this?

https://codereview.chromium.org/2849043002/diff/300001/media/base/overlay_info.h
File media/base/overlay_info.h (right):

https://codereview.chromium.org/2849043002/diff/300001/media/base/overlay_inf...
media/base/overlay_info.h:5: #ifndef MEDIA_BASE_OVERLAY_INFORMATION_H_
NIT: s/INFORMATION/INFO

[liberato (no reviews please), 2017-05-12 21:32:06]

The CQ bit was checked by liberato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 21:34:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 21:41:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 21:41:32]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_optional_gpu_tests_rel on master.tryserver.chromium.android
(JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_opti...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[liberato (no reviews please), 2017-05-12 21:42:50]

https://codereview.chromium.org/2849043002/diff/300001/media/base/media_switc...
File media/base/media_switches.h (right):

https://codereview.chromium.org/2849043002/diff/300001/media/base/media_switc...
media/base/media_switches.h:118: MEDIA_EXPORT extern const base::Feature
kAndroidMediaPlayerRenderer;
On 2017/05/12 21:11:11, tguilbert wrote:
> watk@ pointed out that kAndroidMediaPlayerRenderer is no longer used. Can you
> remove this, unless watk@ has a CL that already does this?

Done.

https://codereview.chromium.org/2849043002/diff/300001/media/base/overlay_info.h
File media/base/overlay_info.h (right):

https://codereview.chromium.org/2849043002/diff/300001/media/base/overlay_inf...
media/base/overlay_info.h:5: #ifndef MEDIA_BASE_OVERLAY_INFORMATION_H_
On 2017/05/12 21:11:11, tguilbert wrote:
> NIT: s/INFORMATION/INFO

Done.

[liberato (no reviews please), 2017-05-12 21:43:25]

The CQ bit was checked by liberato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 21:44:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[liberato (no reviews please), 2017-05-12 22:18:07]

liberato@chromium.org changed reviewers:
+ alokp@chromium.org, nasko@chromium.org

[liberato (no reviews please), 2017-05-12 22:23:42]

hi all

aelias: PTAL @ render_frame_impl .

nasko: PTAL @ media/gpu/ipc .

alokp: PTAL @ chromecast/ .

watk, tguilbert: thanks for your feedback.

thanks
-fl

[alokp, 2017-05-12 22:42:51]

chromecast/ lgtm

[commit-bot: I haz the power, 2017-05-12 22:46:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 22:46:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[liberato (no reviews please), 2017-05-16 20:37:53]

liberato@chromium.org changed reviewers:
+ kenrb@chromium.org
- nasko@chromium.org

[liberato (no reviews please), 2017-05-16 20:38:42]

liberato@chromium.org changed reviewers:
+ aelias@chromium.org

[liberato (no reviews please), 2017-05-16 20:39:58]

hi all

kenrb: PTAL @ media/gpu/ipc (swapping out nasko@ since he's listed as 'out').

thanks
-fl

[kenrb, 2017-05-16 20:50:41]

ipc lgtm

[liberato (no reviews please), 2017-05-16 21:10:11]

aelias: i entirely forgot to mention why i added you to this review a few
minutes ago.  PTAL @ render_frame_impl .  sorry about that!

kenrb, alokp: thanks for the feedback.

thanks
-fl

[aelias_OOO_until_Jul13, 2017-05-16 21:51:12]

render_frame_impl lgtm

[liberato (no reviews please), 2017-05-16 21:56:28]

The CQ bit was checked by liberato@chromium.org

[liberato (no reviews please), 2017-05-16 21:56:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
tguilbert@chromium.org, alokp@chromium.org
Link to the patchset: https://codereview.chromium.org/2849043002/#ps360001
(title: "rebased")

[commit-bot: I haz the power, 2017-05-16 21:58:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 23:40:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 23:40:50]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[liberato (no reviews please), 2017-05-17 05:46:23]

The CQ bit was checked by liberato@chromium.org

[commit-bot: I haz the power, 2017-05-17 05:47:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 07:28:27]

CQ is committing da patch.

Bot data: {"patchset_id": 360001, "attempt_start_ts": 1494999983950840,
"parent_rev": "d91d54ced7ed0c79f8140e232f4b6b80efb5921d", "commit_rev":
"2ff93adf7ed746c0e945c250e52b8d30adfbf719"}

[commit-bot: I haz the power, 2017-05-17 07:28:37]

Description was changed from

==========
Send AndroidOverlay routing token from WMPI to AVDA.

This CL makes WMPI mirror the CVV surface ID logic with routing
tokens for AndroidOverlay.  The routing token is sent to AVDA, which
does nothing with it.

This CL also splits the existing RequestSurfaceCB into two separate
callbacks.  RequestSurfaceCB remains unchanged, providing a CVV id.
This CL adds Request/Provide OverlayInfoCB to send the CVV id and/or
the routing token.  Most existing instances of R/P SurfaceCB are
now R/P OverlayInfoCB instead, since everything from AVDA up to WMPI
really wants whatever info it needs to create overlays.

BUG=719693
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Send AndroidOverlay routing token from WMPI to AVDA.

This CL makes WMPI mirror the CVV surface ID logic with routing
tokens for AndroidOverlay.  The routing token is sent to AVDA, which
does nothing with it.

This CL also splits the existing RequestSurfaceCB into two separate
callbacks.  RequestSurfaceCB remains unchanged, providing a CVV id.
This CL adds Request/Provide OverlayInfoCB to send the CVV id and/or
the routing token.  Most existing instances of R/P SurfaceCB are
now R/P OverlayInfoCB instead, since everything from AVDA up to WMPI
really wants whatever info it needs to create overlays.

BUG=719693
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2849043002
Cr-Commit-Position: refs/heads/master@{#472369}
Committed:
https://chromium.googlesource.com/chromium/src/+/2ff93adf7ed746c0e945c250e52b...
==========

[commit-bot: I haz the power, 2017-05-17 07:28:39]

Committed patchset #19 (id:360001) as
https://chromium.googlesource.com/chromium/src/+/2ff93adf7ed746c0e945c250e52b...