Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6596)

Unified Diff: chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc

Issue 2848983002: MD Settings: mergeable "View password" button fix (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc
diff --git a/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc b/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc
index 704b2cc533a95b786b8d49d2bfdf3bea7c8387af..380e99ac88bcc5d7da218234202f7d2dc9ec6f4e 100644
--- a/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc
+++ b/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc
@@ -17,6 +17,7 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/common/extensions/api/passwords_private.h"
#include "content/public/browser/browser_context.h"
+#include "url/gurl.h"
namespace extensions {
@@ -73,7 +74,8 @@ void PasswordsPrivateEventRouter::OnPlaintextPasswordFetched(
const std::string& username,
const std::string& plaintext_password) {
api::passwords_private::PlaintextPasswordEventParameters params;
- params.login_pair.urls.origin = origin_url;
+ // TODO(crbug.com/715866): use origins and URLs more consistently.
+ params.login_pair.urls.origin = GURL(origin_url).GetOrigin().spec();
params.login_pair.username = username;
params.plaintext_password = plaintext_password;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698