Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2848973003: MD Settings: convert paper-icon-button to paper-icon-button-light. (Closed)

Created:
3 years, 7 months ago by scottchen
Modified:
3 years, 6 months ago
CC:
chromium-reviews, dbeam+watch-elements_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, dbeam+watch-settings_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: convert paper-icon-button to paper-icon-button-light. With this CL, grepping "chrome/browser/resources/settings/" for "<paper-icon-button" should find nothing. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2848973003 Cr-Commit-Position: refs/heads/master@{#479874} Committed: https://chromium.googlesource.com/chromium/src/+/bf4adbb1a2b7066a30297d5df51707fd468d391d

Patch Set 1 #

Patch Set 2 : search engine #

Patch Set 3 : bluetooth list item #

Patch Set 4 : cert #

Patch Set 5 : known networks #

Patch Set 6 : language page #

Patch Set 7 : autofill #

Patch Set 8 : saved passwords #

Patch Set 9 : cups printer list #

Patch Set 10 : search engines entry and omnibox extensions entry #

Patch Set 11 : protocol handler #

Patch Set 12 : usb devices #

Patch Set 13 : remove unnecessary class and attribute #

Patch Set 14 : just looked at design, apparently we always wanted alginment but didnt have it. #

Patch Set 15 : user-list, edit-dictionary-page #

Patch Set 16 : site data details, password exception list #

Patch Set 17 : cr:delete #

Patch Set 18 : cups printer dialog #

Patch Set 19 : subpage search #

Patch Set 20 : password dialog, profile page camera #

Patch Set 21 : format #

Total comments: 2

Patch Set 22 : add missing files #

Total comments: 15

Patch Set 23 : merge #

Patch Set 24 : feedback #

Patch Set 25 : feedback #

Patch Set 26 : merge #

Patch Set 27 : fix merge #

Patch Set 28 : clean up duplicate after merge #

Patch Set 29 : move cr icon classes to its own file #

Patch Set 30 : merge #

Patch Set 31 : merge #

Patch Set 32 : move more icons to classes #

Total comments: 18

Patch Set 33 : feedback #

Total comments: 12

Patch Set 34 : feedback #

Patch Set 35 : feedback and formatting #

Total comments: 4

Patch Set 36 : remove unnecessary assets from resources #

Total comments: 2

Patch Set 37 : fix some tests #

Patch Set 38 : fix more test #

Patch Set 39 : add images in shared location to grd files #

Total comments: 2

Patch Set 40 : fix indentation #

Patch Set 41 : move unrelated fix to another CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -218 lines) Patch
M chrome/browser/resources/settings/a11y_page/manage_a11y_page.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/device_page/storage.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/settings/icons.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 3 chunks +0 lines, -6 lines 0 comments Download
A chrome/browser/resources/settings/images/settings_icon_add_circle.svg View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/resources/settings/images/settings_icon_add_wifi.svg View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/resources/settings/images/settings_icon_arrow_back.svg View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/resources/settings/images/settings_icon_camera_alt.svg View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/resources/settings/images/settings_icon_flip.svg View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/resources/settings/images/settings_icon_visibility.svg View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_known_networks_page.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_subpage.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/resources/settings/languages_page/edit_dictionary_page.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/languages_page/languages_page.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/on_startup_page/startup_url_entry.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 3 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 3 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/password_list_item.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/people_page/camera.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 4 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/resources/settings/people_page/change_picture.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/people_page/fingerprint_list.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/resources/settings/people_page/user_list.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/printing_page/cups_printers_list.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/search_engines_page/search_engine_entry.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/search_engines_page/search_engine_entry.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 2 chunks +4 lines, -4 lines 0 comments Download
A chrome/browser/resources/settings/settings_icons_css.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/settings_subpage.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_shared_css.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 3 chunks +15 lines, -18 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/protocol_handlers.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_data.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_data_details_subpage.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_details.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_list.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/usb_devices.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/zoom_levels.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/test/data/webui/settings/languages_page_tests.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/data/webui/settings/protocol_handlers_tests.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/webui/settings/search_engines_page_test.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/data/webui/settings/settings_autofill_section_browsertest.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/data/webui/settings/settings_subpage_test.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/webui/settings/usb_devices_tests.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/data/webui/settings/zoom_levels_tests.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +1 line, -1 line 0 comments Download
A ui/webui/resources/cr_elements/cr_icons_css.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 1 chunk +49 lines, -0 lines 0 comments Download
M ui/webui/resources/cr_elements/shared_style_css.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 3 chunks +3 lines, -24 lines 0 comments Download
M ui/webui/resources/cr_elements/shared_vars_css.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 1 chunk +3 lines, -1 line 0 comments Download
M ui/webui/resources/cr_elements_images.grdp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 1 chunk +14 lines, -0 lines 0 comments Download
M ui/webui/resources/cr_elements_resources.grdp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 1 chunk +5 lines, -2 lines 0 comments Download
A ui/webui/resources/images/icon_arrow_dropdown.svg View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 1 chunk +1 line, -0 lines 0 comments Download
A ui/webui/resources/images/icon_clear.svg View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +1 line, -0 lines 0 comments Download
A ui/webui/resources/images/icon_delete.svg View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +1 line, -0 lines 0 comments Download
A ui/webui/resources/images/icon_more_vert.svg View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 1 chunk +1 line, -0 lines 0 comments Download
A ui/webui/resources/images/icon_search.svg View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 1 chunk +1 line, -0 lines 0 comments Download
A ui/webui/resources/images/icon_settings.svg View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 63 (29 generated)
scottchen
Sorry - I know this CL looks gigantic.. but I swear very few lines changed ...
3 years, 7 months ago (2017-05-03 23:18:14 UTC) #3
stevenjb
https://codereview.chromium.org/2848973003/diff/380001/chrome/browser/resources/settings/people_page/user_list.html File chrome/browser/resources/settings/people_page/user_list.html (right): https://codereview.chromium.org/2848973003/diff/380001/chrome/browser/resources/settings/people_page/user_list.html#newcode38 chrome/browser/resources/settings/people_page/user_list.html:38: background-color: transparent; Ah. Hrm. I'd rather modify [scrollable] :focus ...
3 years, 7 months ago (2017-05-03 23:58:59 UTC) #5
dschuyler
https://codereview.chromium.org/2848973003/diff/380001/ui/webui/resources/cr_elements_images.grdp File ui/webui/resources/cr_elements_images.grdp (right): https://codereview.chromium.org/2848973003/diff/380001/ui/webui/resources/cr_elements_images.grdp#newcode18 ui/webui/resources/cr_elements_images.grdp:18: file="images/icon_settings.svg" type="BINDATA" /> I only see one of these ...
3 years, 7 months ago (2017-05-08 19:05:29 UTC) #6
scottchen
On 2017/05/08 19:05:29, dschuyler wrote: > https://codereview.chromium.org/2848973003/diff/380001/ui/webui/resources/cr_elements_images.grdp > File ui/webui/resources/cr_elements_images.grdp (right): > > https://codereview.chromium.org/2848973003/diff/380001/ui/webui/resources/cr_elements_images.grdp#newcode18 > ...
3 years, 7 months ago (2017-05-22 17:39:46 UTC) #7
Dan Beam
is there a way we don't have to keep copying these svgs everywhere? https://codereview.chromium.org/2848973003/diff/400001/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.js File ...
3 years, 7 months ago (2017-05-23 16:36:22 UTC) #8
stevenjb
https://codereview.chromium.org/2848973003/diff/400001/chrome/browser/resources/settings/people_page/user_list.html File chrome/browser/resources/settings/people_page/user_list.html (right): https://codereview.chromium.org/2848973003/diff/400001/chrome/browser/resources/settings/people_page/user_list.html#newcode39 chrome/browser/resources/settings/people_page/user_list.html:39: } I'd still prefer to make this change globally ...
3 years, 7 months ago (2017-05-23 22:16:02 UTC) #9
stevenjb
https://codereview.chromium.org/2848973003/diff/400001/chrome/browser/resources/settings/people_page/user_list.html File chrome/browser/resources/settings/people_page/user_list.html (right): https://codereview.chromium.org/2848973003/diff/400001/chrome/browser/resources/settings/people_page/user_list.html#newcode39 chrome/browser/resources/settings/people_page/user_list.html:39: } On 2017/05/23 22:16:02, stevenjb wrote: > I'd still ...
3 years, 7 months ago (2017-05-23 23:19:24 UTC) #10
scottchen
https://codereview.chromium.org/2848973003/diff/400001/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.js File chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.js (right): https://codereview.chromium.org/2848973003/diff/400001/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.js#newcode37 chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.js:37: this.$$('button[is="paper-icon-button-light"]')) On 2017/05/23 16:36:22, Dan Beam wrote: > curlies ...
3 years, 6 months ago (2017-05-27 00:18:03 UTC) #11
dschuyler
On 2017/05/03 23:18:14, scottchen wrote: > Sorry - I know this CL looks gigantic.. but ...
3 years, 6 months ago (2017-05-30 18:34:20 UTC) #12
scottchen
On 2017/05/30 18:34:20, dschuyler wrote: > On 2017/05/03 23:18:14, scottchen wrote: > > Sorry - ...
3 years, 6 months ago (2017-05-30 19:33:05 UTC) #13
Dan Beam
ok, i think we have a few options here: 1. <button is="paper-icon-button-light"> <iron-icon icon="..."></iron-icon> </button> ...
3 years, 6 months ago (2017-05-31 00:40:16 UTC) #14
scottchen
> 3. > > flattenhtml="true" in .grd > <style> .blah { background: url(blah.svg); } </style> ...
3 years, 6 months ago (2017-05-31 00:48:42 UTC) #15
dschuyler
On 2017/05/31 00:40:16, Dan Beam wrote: > ok, i think we have a few options ...
3 years, 6 months ago (2017-05-31 00:59:44 UTC) #16
Dan Beam
On 2017/05/31 00:59:44, dschuyler wrote: > On 2017/05/31 00:40:16, Dan Beam wrote: > > ok, ...
3 years, 6 months ago (2017-05-31 01:12:06 UTC) #17
scottchen
On 2017/05/31 01:12:06, Dan Beam wrote: > > dschuyler@: yes, <style>s are no longer duplicated, ...
3 years, 6 months ago (2017-05-31 18:44:47 UTC) #18
dschuyler
On 2017/05/31 18:44:47, scottchen wrote: > On 2017/05/31 01:12:06, Dan Beam wrote: > > > ...
3 years, 6 months ago (2017-05-31 18:54:32 UTC) #19
Dan Beam
On 2017/05/31 18:44:47, scottchen wrote: > On 2017/05/31 01:12:06, Dan Beam wrote: > > > ...
3 years, 6 months ago (2017-05-31 20:53:51 UTC) #20
scottchen
I've made a few new CSS files based on discussed solutions and converted more <iron-icons> ...
3 years, 6 months ago (2017-06-06 00:46:14 UTC) #22
dschuyler
https://codereview.chromium.org/2848973003/diff/620001/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html File chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html (right): https://codereview.chromium.org/2848973003/diff/620001/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html#newcode4 chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html:4: <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.html"> Is this still needed? https://codereview.chromium.org/2848973003/diff/620001/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html#newcode39 chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html:39: ...
3 years, 6 months ago (2017-06-06 18:58:40 UTC) #23
scottchen
https://codereview.chromium.org/2848973003/diff/620001/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html File chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html (right): https://codereview.chromium.org/2848973003/diff/620001/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html#newcode4 chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html:4: <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.html"> On 2017/06/06 18:58:39, dschuyler wrote: > ...
3 years, 6 months ago (2017-06-06 22:33:12 UTC) #24
dschuyler
https://codereview.chromium.org/2848973003/diff/640001/chrome/browser/resources/settings/internet_page/internet_subpage.html File chrome/browser/resources/settings/internet_page/internet_subpage.html (right): https://codereview.chromium.org/2848973003/diff/640001/chrome/browser/resources/settings/internet_page/internet_subpage.html#newcode62 chrome/browser/resources/settings/internet_page/internet_subpage.html:62: <iron-icon icon="settings:add-wifi"></iron-icon> Thanks for removing iron-icon in other files ...
3 years, 6 months ago (2017-06-07 23:21:22 UTC) #25
scottchen
https://codereview.chromium.org/2848973003/diff/640001/chrome/browser/resources/settings/internet_page/internet_subpage.html File chrome/browser/resources/settings/internet_page/internet_subpage.html (right): https://codereview.chromium.org/2848973003/diff/640001/chrome/browser/resources/settings/internet_page/internet_subpage.html#newcode62 chrome/browser/resources/settings/internet_page/internet_subpage.html:62: <iron-icon icon="settings:add-wifi"></iron-icon> On 2017/06/07 23:21:21, dschuyler wrote: > Thanks ...
3 years, 6 months ago (2017-06-08 22:13:15 UTC) #26
dschuyler
https://codereview.chromium.org/2848973003/diff/680001/ui/webui/resources/cr_elements_images.grdp File ui/webui/resources/cr_elements_images.grdp (right): https://codereview.chromium.org/2848973003/diff/680001/ui/webui/resources/cr_elements_images.grdp#newcode24 ui/webui/resources/cr_elements_images.grdp:24: file="images/icon_arrow_dropdown.svg" type="BINDATA" /> I think these may not be ...
3 years, 6 months ago (2017-06-09 22:30:46 UTC) #27
scottchen
https://codereview.chromium.org/2848973003/diff/680001/ui/webui/resources/cr_elements_images.grdp File ui/webui/resources/cr_elements_images.grdp (right): https://codereview.chromium.org/2848973003/diff/680001/ui/webui/resources/cr_elements_images.grdp#newcode24 ui/webui/resources/cr_elements_images.grdp:24: file="images/icon_arrow_dropdown.svg" type="BINDATA" /> On 2017/06/09 22:30:46, dschuyler wrote: > ...
3 years, 6 months ago (2017-06-09 23:19:26 UTC) #28
dschuyler
lgtm https://codereview.chromium.org/2848973003/diff/700001/chrome/browser/resources/settings/settings_icons_css.html File chrome/browser/resources/settings/settings_icons_css.html (right): https://codereview.chromium.org/2848973003/diff/700001/chrome/browser/resources/settings/settings_icons_css.html#newcode8 chrome/browser/resources/settings/settings_icons_css.html:8: background-image: url(./images/settings_icon_arrow_back.svg); nit: maybe go without the ./
3 years, 6 months ago (2017-06-09 23:48:03 UTC) #29
scottchen
https://codereview.chromium.org/2848973003/diff/700001/chrome/browser/resources/settings/settings_icons_css.html File chrome/browser/resources/settings/settings_icons_css.html (right): https://codereview.chromium.org/2848973003/diff/700001/chrome/browser/resources/settings/settings_icons_css.html#newcode8 chrome/browser/resources/settings/settings_icons_css.html:8: background-image: url(./images/settings_icon_arrow_back.svg); On 2017/06/09 23:48:03, dschuyler wrote: > nit: ...
3 years, 6 months ago (2017-06-10 00:15:22 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848973003/700001
3 years, 6 months ago (2017-06-10 00:15:56 UTC) #32
scottchen
dbeam@ stevenjb@ PTAL.
3 years, 6 months ago (2017-06-10 00:22:54 UTC) #34
scottchen
dschuyler@ as mentioned offline, I had to add the cr_elements svg images back into the ...
3 years, 6 months ago (2017-06-14 00:15:13 UTC) #52
Dan Beam
rs lgtm https://codereview.chromium.org/2848973003/diff/780001/chrome/browser/resources/settings/settings_icons_css.html File chrome/browser/resources/settings/settings_icons_css.html (right): https://codereview.chromium.org/2848973003/diff/780001/chrome/browser/resources/settings/settings_icons_css.html#newcode13 chrome/browser/resources/settings/settings_icons_css.html:13: <if expr="chromeos"> ideally, this <if> should be ...
3 years, 6 months ago (2017-06-14 01:19:22 UTC) #55
scottchen
https://codereview.chromium.org/2848973003/diff/780001/chrome/browser/resources/settings/settings_icons_css.html File chrome/browser/resources/settings/settings_icons_css.html (right): https://codereview.chromium.org/2848973003/diff/780001/chrome/browser/resources/settings/settings_icons_css.html#newcode13 chrome/browser/resources/settings/settings_icons_css.html:13: <if expr="chromeos"> On 2017/06/14 01:19:21, Dan Beam wrote: > ...
3 years, 6 months ago (2017-06-14 17:40:42 UTC) #56
dschuyler
On 2017/06/14 00:15:13, scottchen wrote: > dschuyler@ as mentioned offline, I had to add the ...
3 years, 6 months ago (2017-06-15 20:58:37 UTC) #57
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848973003/820001
3 years, 6 months ago (2017-06-15 21:04:10 UTC) #60
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 22:37:41 UTC) #63
Message was sent while issue was closed.
Committed patchset #41 (id:820001) as
https://chromium.googlesource.com/chromium/src/+/bf4adbb1a2b7066a30297d5df517...

Powered by Google App Engine
This is Rietveld 408576698