chrome/test/data/webui/settings/languages_page_tests.js - Issue 2848973003: MD Settings: convert paper-icon-button to paper-icon-button-light.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/webui/settings/languages_page_tests.js

Issue 2848973003: MD Settings: convert paper-icon-button to paper-icon-button-light. (Closed)

Patch Set: move unrelated fix to another CL Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/site_settings/zoom_levels.html ('k') | chrome/test/data/webui/settings/protocol_handlers_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/webui/settings/languages_page_tests.js

diff --git a/chrome/test/data/webui/settings/languages_page_tests.js b/chrome/test/data/webui/settings/languages_page_tests.js

index 5779f861ded7d23de51d0340d5639440e31ecef0..e6d3cdad8aedc2a0fe6bedd7ef8f17d14c96ff51 100644

--- a/chrome/test/data/webui/settings/languages_page_tests.js

+++ b/chrome/test/data/webui/settings/languages_page_tests.js

@@ -216,7 +216,7 @@ cr.define('languages_page_tests', function() {

test('structure', function() {

var languageOptionsDropdownTrigger = languagesCollapse.querySelector(

- 'paper-icon-button');

+ 'button');

assertTrue(!!languageOptionsDropdownTrigger);

MockInteractions.tap(languageOptionsDropdownTrigger);

assertTrue(actionMenu.open);

@@ -252,7 +252,7 @@ cr.define('languages_page_tests', function() {

test('toggle translate for a specific language', function(done) {

// Open options for 'sw'.

var languageOptionsDropdownTrigger =

- languagesCollapse.querySelectorAll('paper-icon-button')[1];

+ languagesCollapse.querySelectorAll('button')[1];

assertTrue(!!languageOptionsDropdownTrigger);

MockInteractions.tap(languageOptionsDropdownTrigger);

assertTrue(actionMenu.open);

@@ -283,7 +283,7 @@ cr.define('languages_page_tests', function() {

// Open options for 'sw'.

var languageOptionsDropdownTrigger =

- languagesCollapse.querySelectorAll('paper-icon-button')[1];

+ languagesCollapse.querySelectorAll('button')[1];

assertTrue(!!languageOptionsDropdownTrigger);

MockInteractions.tap(languageOptionsDropdownTrigger);

assertTrue(actionMenu.open);

@@ -311,7 +311,7 @@ cr.define('languages_page_tests', function() {

});

// Open the menu and select Remove.

- MockInteractions.tap(item.querySelector('paper-icon-button'));

+ MockInteractions.tap(item.querySelector('button'));

assertTrue(actionMenu.open);

var removeMenuItem = getMenuItem('removeLanguage');

@@ -332,7 +332,7 @@ cr.define('languages_page_tests', function() {

var menuButtons =

languagesCollapse.querySelectorAll(

- '.list-item paper-icon-button[icon="cr:more-vert"]');

+ '.list-item button.icon-more-vert');

// First language should not have "Move up" or "Move to top".

MockInteractions.tap(menuButtons[0]);