Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 2848933002: Reland of SharedArrayBuffer throws serializing to indexeddb (Closed)

Created:
3 years, 7 months ago by binji
Modified:
3 years, 7 months ago
Reviewers:
haraken, gab, jbroman, jsbell
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, cmumford, jbroman+watch_chromium.org, jsbell+idb_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of SharedArrayBuffer throws serializing to indexeddb (patchset #1 id:1 of https://codereview.chromium.org/2845623002/ ) Reason for revert: This CL was speculatively suspected as the cause of http://crbug.com/715567, but it turned out was unrelated. Original issue's description: > Revert of SharedArrayBuffer throws serializing to indexeddb (patchset #4 id:60001 of https://codereview.chromium.org/2838783002/ ) > > Reason for revert: > Suspect for http://crbug.com/715567 (crash when typing in hangouts chat window). > > Original issue's description: > > SharedArrayBuffer throws serializing to indexeddb > > > > The StructuredDeserialize spec now has a special case for serializing > > for storage: it doesn't allow SharedArrayBuffers to be serialized, and > > instead throws a DataCloneError. > > > > BUG=chromium:714820 > > > > Review-Url: https://codereview.chromium.org/2838783002 > > Cr-Commit-Position: refs/heads/master@{#467093} > > Committed: https://chromium.googlesource.com/chromium/src/+/08d35f601c7cfbdc66f9a7f8836e32028d344559 > > TBR=jbroman@chromium.org,haraken@chromium.org,jsbell@chromium.org,binji@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:714820 > > Review-Url: https://codereview.chromium.org/2845623002 > Cr-Commit-Position: refs/heads/master@{#467325} > Committed: https://chromium.googlesource.com/chromium/src/+/d86073fac8a47abe754598992e1b8424d7534b9f TBR=jbroman@chromium.org,haraken@chromium.org,jsbell@chromium.org,gab@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:714820 Review-Url: https://codereview.chromium.org/2848933002 Cr-Commit-Position: refs/heads/master@{#468084} Committed: https://chromium.googlesource.com/chromium/src/+/14ddf4a2b43673a91f552143adb6e7cf03acbb8b

Patch Set 1 #

Messages

Total messages: 9 (3 generated)
binji
Created Reland of SharedArrayBuffer throws serializing to indexeddb
3 years, 7 months ago (2017-04-28 17:10:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848933002/1
3 years, 7 months ago (2017-04-28 17:11:10 UTC) #3
gab
lgtm, apologies for incorrect revert
3 years, 7 months ago (2017-04-28 17:57:45 UTC) #4
binji
On 2017/04/28 at 17:57:45, gab wrote: > lgtm, apologies for incorrect revert np, it looked ...
3 years, 7 months ago (2017-04-28 17:59:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/14ddf4a2b43673a91f552143adb6e7cf03acbb8b
3 years, 7 months ago (2017-04-28 19:08:51 UTC) #8
haraken
3 years, 7 months ago (2017-04-29 02:29:16 UTC) #9
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698