Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issue 2845623002: Revert of SharedArrayBuffer throws serializing to indexeddb (Closed)

Created:
3 years, 8 months ago by gab
Modified:
3 years, 8 months ago
Reviewers:
haraken, jbroman, binji, jsbell
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, cmumford, haraken, jbroman+watch_chromium.org, jsbell+idb_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of SharedArrayBuffer throws serializing to indexeddb (patchset #4 id:60001 of https://codereview.chromium.org/2838783002/ ) Reason for revert: Suspect for http://crbug.com/715567 (crash when typing in hangouts chat window). Original issue's description: > SharedArrayBuffer throws serializing to indexeddb > > The StructuredDeserialize spec now has a special case for serializing > for storage: it doesn't allow SharedArrayBuffers to be serialized, and > instead throws a DataCloneError. > > BUG=chromium:714820 > > Review-Url: https://codereview.chromium.org/2838783002 > Cr-Commit-Position: refs/heads/master@{#467093} > Committed: https://chromium.googlesource.com/chromium/src/+/08d35f601c7cfbdc66f9a7f8836e32028d344559 TBR=jbroman@chromium.org,haraken@chromium.org,jsbell@chromium.org,binji@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:714820 Review-Url: https://codereview.chromium.org/2845623002 Cr-Commit-Position: refs/heads/master@{#467325} Committed: https://chromium.googlesource.com/chromium/src/+/d86073fac8a47abe754598992e1b8424d7534b9f

Patch Set 1 #

Messages

Total messages: 8 (4 generated)
gab
Created Revert of SharedArrayBuffer throws serializing to indexeddb
3 years, 8 months ago (2017-04-26 14:51:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845623002/1
3 years, 8 months ago (2017-04-26 14:52:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/d86073fac8a47abe754598992e1b8424d7534b9f
3 years, 8 months ago (2017-04-26 14:53:06 UTC) #7
binji
3 years, 7 months ago (2017-04-28 17:10:38 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2848933002/ by binji@chromium.org.

The reason for reverting is: This CL was speculatively suspected as the cause of
http://crbug.com/715567, but it turned out was unrelated..

Powered by Google App Engine
This is Rietveld 408576698