Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2848743003: Speed up CredentialsContainer::get for federations (Closed)

Created:
3 years, 7 months ago by jdoerrie
Modified:
3 years, 7 months ago
Reviewers:
Mike West
CC:
blink-reviews, chromium-reviews, haraken
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Speed up CredentialsContainer::get for federations This change removes two unnecessary copies in CredentialsContainer::get when federations are present in the CredentialRequestOptions. BUG=400674 Review-Url: https://codereview.chromium.org/2848743003 Cr-Commit-Position: refs/heads/master@{#468585} Committed: https://chromium.googlesource.com/chromium/src/+/7c599d9955031405b5187f9ecdf231cfe5fc7467

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp View 2 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jdoerrie
Hi Mike, I just stumbled across this. Since https://crbug.com/587088 got fixed in the meantime I ...
3 years, 7 months ago (2017-04-28 13:18:18 UTC) #4
Mike West
LGTM, thanks.
3 years, 7 months ago (2017-05-02 07:04:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848743003/1
3 years, 7 months ago (2017-05-02 07:06:07 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 09:02:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7c599d9955031405b5187f9ecdf2...

Powered by Google App Engine
This is Rietveld 408576698