Speed up CredentialsContainer::get for federations

third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/credentialmanager/CredentialsContainer.h"
 
 #include <memory>
+#include <utility>
 #include "bindings/core/v8/Dictionary.h"
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "core/dom/DOMException.h"
 #include "core/dom/Document.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/dom/ExecutionContext.h"
 #include "core/frame/Frame.h"
 #include "core/frame/UseCounter.h"
 #include "core/page/FrameTree.h"
@@ skipping 142 matching lines @@
 ScriptPromise CredentialsContainer::get(
     ScriptState* script_state,
     const CredentialRequestOptions& options) {
   ScriptPromiseResolver* resolver = ScriptPromiseResolver::Create(script_state);
   ScriptPromise promise = resolver->Promise();
   if (!CheckBoilerplate(resolver))
     return promise;
 
   Vector<KURL> providers;
   if (options.hasFederated() && options.federated().hasProviders()) {
-    // TODO(mkwst): CredentialRequestOptions::federated() needs to return a
-    // reference, not a value.  Because it returns a temporary value now, a for
-    // loop that directly references the value generates code that holds a
-    // reference to a value that no longer exists by the time the loop starts
-    // looping. In order to avoid this crazyness for the moment, we're making a
-    // copy of the vector. https://crbug.com/587088
-    const Vector<String> provider_strings = options.federated().providers();
-    for (const auto& string : provider_strings) {
+    for (const auto& string : options.federated().providers()) {
       KURL url = KURL(KURL(), string);
       if (url.IsValid())
-        providers.push_back(url);
+        providers.push_back(std::move(url));
     }
   }
 
   UseCounter::Count(ExecutionContext::From(script_state),
                     options.unmediated()
                         ? UseCounter::kCredentialManagerGetWithoutUI
                         : UseCounter::kCredentialManagerGetWithUI);
 
   CredentialManagerClient::From(ExecutionContext::From(script_state))
       ->DispatchGet(options.unmediated(), options.password(), providers,
@@ skipping 21 matching lines @@
   ScriptPromise promise = resolver->Promise();
   if (!CheckBoilerplate(resolver))
     return promise;
 
   CredentialManagerClient::From(ExecutionContext::From(script_state))
       ->DispatchRequireUserMediation(new NotificationCallbacks(resolver));
   return promise;
 }
 
 }  // namespace blink