[Desktop FRE] Fix incorrect emission of histogram

[Desktop FRE] Fix incorrect emission of histogram

This CL fixes a bug where the Welcome.Win10.NewPromoPageAdded histogram
is emitted for the wrong page--it is meant to track chrome://welcome-win10,
which corresponds to Welcome.Win10.OldPromoPageAdded tracking the old
default browser promo. This CL also addresses a refactoring nit requested
in a prior review.

BUG=688574
Review-Url: https://codereview.chromium.org/2848713002
Cr-Commit-Position: refs/heads/master@{#470218}
Committed: https://chromium.googlesource.com/chromium/src/+/4000f08774959883da8bef366561798e98cb50eb

[tmartino, 2017-04-27 18:44:45]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 18:45:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 19:53:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 19:53:27]

Dry run: This issue passed the CQ dry run.

[tmartino, 2017-04-27 22:22:31]

Description was changed from

==========
[Desktop FRE] Fix incorrect emission of histogram

BUG=
==========

to

==========
[Desktop FRE] Fix incorrect emission of histogram

This CL fixes a bug where the Welcome.Win10.NewPromoPageAdded histogram
is emitted for the wrong page--it is meant to track chrome://welcome-win10,
which corresponds to Welcome.Win10.OldPromoPageAdded tracking the old
default browser promo. This CL also addresses a refactoring nit requested
in a prior review.

BUG=688574
==========

[tmartino, 2017-04-27 22:22:31]

tmartino@chromium.org changed reviewers:
+ pkasting@chromium.org

[Peter Kasting, 2017-05-05 22:43:10]

LGTM

[tmartino, 2017-05-08 20:44:57]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 20:45:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 00:44:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 00:44:59]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tmartino, 2017-05-09 04:29:49]

The CQ bit was checked by tmartino@chromium.org

[commit-bot: I haz the power, 2017-05-09 04:31:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 04:42:32]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494304189908660, "parent_rev":
"3f8cdfd3ab1a3e87f90c37f3d7763483ac9e03c4", "commit_rev":
"4000f08774959883da8bef366561798e98cb50eb"}

[commit-bot: I haz the power, 2017-05-09 04:42:40]

Description was changed from

==========
[Desktop FRE] Fix incorrect emission of histogram

This CL fixes a bug where the Welcome.Win10.NewPromoPageAdded histogram
is emitted for the wrong page--it is meant to track chrome://welcome-win10,
which corresponds to Welcome.Win10.OldPromoPageAdded tracking the old
default browser promo. This CL also addresses a refactoring nit requested
in a prior review.

BUG=688574
==========

to

==========
[Desktop FRE] Fix incorrect emission of histogram

This CL fixes a bug where the Welcome.Win10.NewPromoPageAdded histogram
is emitted for the wrong page--it is meant to track chrome://welcome-win10,
which corresponds to Welcome.Win10.OldPromoPageAdded tracking the old
default browser promo. This CL also addresses a refactoring nit requested
in a prior review.

BUG=688574

Review-Url: https://codereview.chromium.org/2848713002
Cr-Commit-Position: refs/heads/master@{#470218}
Committed:
https://chromium.googlesource.com/chromium/src/+/4000f08774959883da8bef366561...
==========

[commit-bot: I haz the power, 2017-05-09 04:42:41]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4000f08774959883da8bef366561...