Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: chrome/browser/ui/startup/startup_tab_provider.cc

Issue 2848713002: [Desktop FRE] Fix incorrect emission of histogram (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/startup/startup_tab_provider.cc
diff --git a/chrome/browser/ui/startup/startup_tab_provider.cc b/chrome/browser/ui/startup/startup_tab_provider.cc
index f8a25f3b2105ad542341855e720e45a2386b0ad8..83ace6eeea1d80f9434931c0ace7635be93d3111 100644
--- a/chrome/browser/ui/startup/startup_tab_provider.cc
+++ b/chrome/browser/ui/startup/startup_tab_provider.cc
@@ -171,10 +171,12 @@ StartupTabs StartupTabProviderImpl::GetWin10OnboardingTabsForState(
if (set_default_browser_allowed && !has_seen_win10_promo &&
!is_default_browser) {
tabs.emplace_back(GetWin10WelcomePageUrl(!is_first_run), false);
- } else if (!has_seen_welcome_page && is_signin_allowed && !is_signed_in) {
- tabs.emplace_back(GetWelcomePageUrl(!is_first_run), false);
+ return tabs;
}
- return tabs;
+
+ return GetStandardOnboardingTabsForState(is_first_run, has_seen_welcome_page,
+ is_signin_allowed, is_signed_in,
+ is_supervised_user);
}
#endif
@@ -245,8 +247,6 @@ StartupTabs StartupTabProviderImpl::GetNewTabPageTabsForState(
// static
GURL StartupTabProviderImpl::GetWelcomePageUrl(bool use_later_run_variant) {
- // Record that the Welcome page was added to the startup url list.
- UMA_HISTOGRAM_BOOLEAN("Welcome.Win10.NewPromoPageAdded", true);
GURL url(chrome::kChromeUIWelcomeURL);
return use_later_run_variant
? net::AppendQueryParameter(url, "variant", "everywhere")
@@ -257,6 +257,8 @@ GURL StartupTabProviderImpl::GetWelcomePageUrl(bool use_later_run_variant) {
// static
GURL StartupTabProviderImpl::GetWin10WelcomePageUrl(
bool use_later_run_variant) {
+ // Record that the Welcome page was added to the startup url list.
+ UMA_HISTOGRAM_BOOLEAN("Welcome.Win10.NewPromoPageAdded", true);
GURL url(chrome::kChromeUIWelcomeWin10URL);
return use_later_run_variant
? net::AppendQueryParameter(url, "text", "faster")
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698