Switch SupportsUserData uses to use unique_ptr.

Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG=690937
Review-Url: https://codereview.chromium.org/2848703004
Cr-Commit-Position: refs/heads/master@{#468128}
Committed: https://chromium.googlesource.com/chromium/src/+/4a402eb1482f1884d7aac7ed59c0da27980ec4c5

[Avi (use Gerrit), 2017-04-28 02:16:12]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 02:16:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 02:57:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 02:58:00]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Avi (use Gerrit), 2017-04-28 03:09:36]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 03:10:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 03:35:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 03:35:08]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Avi (use Gerrit), 2017-04-28 03:38:50]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 03:39:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-04-28 04:19:52]

avi@chromium.org changed reviewers:
+ dewittj@chromium.org

[commit-bot: I haz the power, 2017-04-28 04:40:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 04:40:11]

Dry run: This issue passed the CQ dry run.

[dewittj, 2017-04-28 19:02:19]

lgtm, thanks!

https://codereview.chromium.org/2848703004/diff/40001/components/offline_page...
File components/offline_pages/core/downloads/download_notifying_observer.cc
(right):

https://codereview.chromium.org/2848703004/diff/40001/components/offline_page...
components/offline_pages/core/downloads/download_notifying_observer.cc:41:
base::WrapUnique(new DownloadNotifyingObserver(
nit: rewrite this as:
auto observer =
base::MakeUnique<DownloadNotifyingObserver>(std::move(notifier)...)

[Avi (use Gerrit), 2017-04-28 21:12:51]

https://codereview.chromium.org/2848703004/diff/40001/components/offline_page...
File components/offline_pages/core/downloads/download_notifying_observer.cc
(right):

https://codereview.chromium.org/2848703004/diff/40001/components/offline_page...
components/offline_pages/core/downloads/download_notifying_observer.cc:41:
base::WrapUnique(new DownloadNotifyingObserver(
On 2017/04/28 19:02:19, dewittj wrote:
> nit: rewrite this as:
> auto observer =
> base::MakeUnique<DownloadNotifyingObserver>(std::move(notifier)...)

Sorry, but the constructor isn't public and therefore MakeUnique can't be used.

[Avi (use Gerrit), 2017-04-28 21:12:58]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2017-04-28 21:13:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 21:19:16]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493413978111780,
"parent_rev": "69977173d6c722795da92a821861d520c66ca05e", "commit_rev":
"4a402eb1482f1884d7aac7ed59c0da27980ec4c5"}

[commit-bot: I haz the power, 2017-04-28 21:19:26]

Description was changed from

==========
Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG=690937
==========

to

==========
Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG=690937

Review-Url: https://codereview.chromium.org/2848703004
Cr-Commit-Position: refs/heads/master@{#468128}
Committed:
https://chromium.googlesource.com/chromium/src/+/4a402eb1482f1884d7aac7ed59c0...
==========

[commit-bot: I haz the power, 2017-04-28 21:19:27]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4a402eb1482f1884d7aac7ed59c0...