components/offline_pages/core/background/network_quality_provider_stub.cc - Issue 2848703004: Switch SupportsUserData uses to use unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/core/background/network_quality_provider_stub.cc

Issue 2848703004: Switch SupportsUserData uses to use unique_ptr. (Closed)

Patch Set: rev Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages/core/background/network_quality_provider_stub.h ('k') | components/offline_pages/core/downloads/download_notifying_observer.cc » ('j') | components/offline_pages/core/downloads/download_notifying_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/core/background/network_quality_provider_stub.cc

diff --git a/components/offline_pages/core/background/network_quality_provider_stub.cc b/components/offline_pages/core/background/network_quality_provider_stub.cc

index f4243af9ade2a22c4b13580b38b9c0f0f3b44bb4..9c5cf28f00f5b244ff4514a371e119739efe4c40 100644

--- a/components/offline_pages/core/background/network_quality_provider_stub.cc

+++ b/components/offline_pages/core/background/network_quality_provider_stub.cc

@@ -24,10 +24,10 @@ NetworkQualityProviderStub* NetworkQualityProviderStub::GetUserData(

// static

void NetworkQualityProviderStub::SetUserData(

base::SupportsUserData* supports_user_data,

- NetworkQualityProviderStub* stub) {

+ std::unique_ptr<NetworkQualityProviderStub> stub) {

DCHECK(supports_user_data);

DCHECK(stub);

- supports_user_data->SetUserData(&kOfflineNQPKey, stub);

+ supports_user_data->SetUserData(&kOfflineNQPKey, std::move(stub));

}

void NetworkQualityProviderStub::AddEffectiveConnectionTypeObserver(