Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2848493006: Remove ListValue::Append(raw ptr) on Android (Closed)

Created:
3 years, 7 months ago by vabr (Chromium)
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Remove ListValue::Append(raw ptr) on Android ListValue::Append(raw ptr) is deprecated and the unique_ptr version should be used instead. This CL achieves that on Android specifically. BUG=581865 Review-Url: https://codereview.chromium.org/2811253004 Cr-Commit-Position: refs/heads/master@{#464865} (cherry picked from commit 2f38a9ff1e78023cc3fa341a30448d1b9ca5a891) Review-Url: https://codereview.chromium.org/2848493006 . Cr-Commit-Position: refs/branch-heads/3071@{#289} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/c92df1c2ea02446a46d6e1f51d1eaa117d6e18a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -43 lines) Patch
M base/values.h View 1 chunk +1 line, -1 line 0 comments Download
M base/values.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/bookmarks/partner_bookmarks_shim.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc View 5 chunks +7 lines, -4 lines 0 comments Download
M content/browser/android/java/gin_java_bridge_dispatcher_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/android/java/gin_java_method_invocation_helper.cc View 4 chunks +5 lines, -10 lines 0 comments Download
M content/browser/android/java/gin_java_method_invocation_helper_unittest.cc View 2 chunks +21 lines, -17 lines 0 comments Download
M content/renderer/java/gin_java_bridge_value_converter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/java/gin_java_function_invocation_helper.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
vabr (Chromium)
3 years, 7 months ago (2017-04-28 08:40:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c92df1c2ea02446a46d6e1f51d1eaa117d6e18a2.

Powered by Google App Engine
This is Rietveld 408576698