Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2848493002: [third_party] vendor argparse. (Closed)

Created:
3 years, 8 months ago by iannucci
Modified:
3 years, 7 months ago
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[third_party] vendor argparse. Unfortunately some of the machines we run recipes on are woefully out of date, and there's a bugfix from 2014 in argparse that we need for consistent behavior across platforms. The delta for this argparse v. the old one is very small. You can see the diff here: https://github.com/python/cpython/commit/af26c15110 R=dnj@chromium.org, phajdan.jr@chromium.org BUG= Review-Url: https://codereview.chromium.org/2848493002 Committed: https://github.com/luci/recipes-py/commit/68d2ac243180dbd51a1c3a672874d072235f961a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2388 lines, -2 lines) Patch
M recipe_engine/test.py View 2 chunks +4 lines, -1 line 0 comments Download
A recipe_engine/third_party/README.argparse View 1 chunk +8 lines, -0 lines 0 comments Download
A recipe_engine/third_party/argparse.py View 1 chunk +2374 lines, -0 lines 0 comments Download
M recipes.py View 2 chunks +2 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
iannucci
3 years, 8 months ago (2017-04-27 04:17:07 UTC) #1
dnj
lgtm
3 years, 7 months ago (2017-04-27 17:20:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848493002/1
3 years, 7 months ago (2017-04-29 03:04:43 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-29 03:07:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/68d2ac243180dbd51a1c3a672874d072235...

Powered by Google App Engine
This is Rietveld 408576698