Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2845783002: [recipes.py] Move fetch, lint and bundle parsers to separate modules. (Closed)

Created:
3 years, 7 months ago by iannucci
Modified:
3 years, 7 months ago
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix quotes #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -82 lines) Patch
M recipe_engine/bundle.py View 2 chunks +20 lines, -5 lines 1 comment Download
M recipe_engine/fetch.py View 1 chunk +17 lines, -0 lines 0 comments Download
M recipe_engine/lint_test.py View 2 chunks +17 lines, -4 lines 0 comments Download
M recipes.py View 1 2 3 13 chunks +32 lines, -73 lines 1 comment Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 24 (19 generated)
iannucci
3 years, 7 months ago (2017-04-26 23:14:35 UTC) #1
iannucci
On 2017/04/26 23:14:35, iannucci wrote: (I'll be moving all the other parsers too, obviously, not ...
3 years, 7 months ago (2017-04-26 23:15:35 UTC) #4
dnj
lgtm, comments https://codereview.chromium.org/2845783002/diff/60001/recipe_engine/bundle.py File recipe_engine/bundle.py (right): https://codereview.chromium.org/2845783002/diff/60001/recipe_engine/bundle.py#newcode646 recipe_engine/bundle.py:646: root_package (package.Package) - The recipes script in ...
3 years, 7 months ago (2017-04-27 16:33:53 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845783002/60001
3 years, 7 months ago (2017-04-29 03:49:09 UTC) #21
commit-bot: I haz the power
3 years, 7 months ago (2017-04-29 03:52:05 UTC) #24
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://github.com/luci/recipes-py/commit/ffe0201f64d5cd7b2cd6a458f8f1414a012...

Powered by Google App Engine
This is Rietveld 408576698