Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2848473002: cros: Enable encryption migration UI by default. (Closed)

Created:
3 years, 7 months ago by fukino
Modified:
3 years, 7 months ago
Reviewers:
xiyuan, Ilya Sherman
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

cros: Enable encryption migration UI by default. Now that the back-end migration logic is ready, we should enable the migration UI by default. This CL does: - Modify encryption migration's flag type from SINGLE_VALUE_TYPE to ENABLE_DISABLE_VALUE_TYPE to have a default value. - Enable encryption migration by default on ToT. BUG=713454 TEST=manually tested the #enable-encryption-migration flag that "Enabled" and "Default" shows migration UI and "Disabled" doesn't. TBR=xiyuan@chromium.org,isherman@chromium.org Review-Url: https://codereview.chromium.org/2830933004 Cr-Commit-Position: refs/heads/master@{#466232} (cherry picked from commit 3e769db4f707bbc5962ee1aa0a1c727081ee754a) Review-Url: https://codereview.chromium.org/2848473002 . Cr-Commit-Position: refs/branch-heads/3071@{#250} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/d5e61d3674614164036a6a3746eb79c26648ac5c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
fukino
3 years, 7 months ago (2017-04-27 01:50:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d5e61d3674614164036a6a3746eb79c26648ac5c.

Powered by Google App Engine
This is Rietveld 408576698