Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1169)

Issue 2830933004: cros: Enable encryption migration UI by default. (Closed)

Created:
3 years, 8 months ago by fukino
Modified:
3 years, 8 months ago
Reviewers:
xiyuan, Ilya Sherman
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, davemoore+watch_chromium.org, asvitkine+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Enable encryption migration UI by default. Now that the back-end migration logic is ready, we should enable the migration UI by default. This CL does: - Modify encryption migration's flag type from SINGLE_VALUE_TYPE to ENABLE_DISABLE_VALUE_TYPE to have a default value. - Enable encryption migration by default on ToT. BUG=713454 TEST=manually tested the #enable-encryption-migration flag that "Enabled" and "Default" shows migration UI and "Disabled" doesn't. Review-Url: https://codereview.chromium.org/2830933004 Cr-Commit-Position: refs/heads/master@{#466232} Committed: https://chromium.googlesource.com/chromium/src/+/3e769db4f707bbc5962ee1aa0a1c727081ee754a

Patch Set 1 #

Patch Set 2 : cros: Enable encryption migration UI by default. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
fukino
Xiyuan, could you take a look?
3 years, 8 months ago (2017-04-20 04:09:22 UTC) #5
xiyuan
lgtm isherman@, could you bless the change in histograms.xml?
3 years, 8 months ago (2017-04-20 14:57:41 UTC) #9
Ilya Sherman
histograms.xml lgtm
3 years, 8 months ago (2017-04-20 20:15:40 UTC) #10
fukino
Thank you!
3 years, 8 months ago (2017-04-21 02:20:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830933004/20001
3 years, 8 months ago (2017-04-21 02:20:45 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 02:25:56 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3e769db4f707bbc5962ee1aa0a1c...

Powered by Google App Engine
This is Rietveld 408576698