Linux native notifications: Implement GetDisplayedNotifications

Linux native notifications: Implement GetDisplayedNotifications

BUG=676220
R=peter@chromium.org
CC=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2848403002
Cr-Commit-Position: refs/heads/master@{#468890}
Committed: https://chromium.googlesource.com/chromium/src/+/cbe7b7a3a4f5839a11461031904555c4c9eac92a

[Tom (Use chromium acct), 2017-05-01 22:00:11]

peter ptal

[Peter Beverloo, 2017-05-02 13:53:43]

https://codereview.chromium.org/2848403002/diff/1/chrome/browser/notification...
File chrome/browser/notifications/notification_platform_bridge_linux.cc (right):

https://codereview.chromium.org/2848403002/diff/1/chrome/browser/notification...
chrome/browser/notifications/notification_platform_bridge_linux.cc:463: }
Are we confident that we can rely on the NotificationClosed signal for all
cases? (User dismisses the notification, we dismiss the notification, it
expires, etcetera?) The docs look good, but just to make sure.

These seem like excellent cases to add tests for by the way.

[Tom (Use chromium acct), 2017-05-02 20:59:16]

https://codereview.chromium.org/2848403002/diff/1/chrome/browser/notification...
File chrome/browser/notifications/notification_platform_bridge_linux.cc (right):

https://codereview.chromium.org/2848403002/diff/1/chrome/browser/notification...
chrome/browser/notifications/notification_platform_bridge_linux.cc:463: }
On 2017/05/02 13:53:42, Peter Beverloo wrote:
> Are we confident that we can rely on the NotificationClosed signal for all
> cases? (User dismisses the notification, we dismiss the notification, it
> expires, etcetera?) The docs look good, but just to make sure.
> 

yes I believe so

> These seem like excellent cases to add tests for by the way.

[Peter Beverloo, 2017-05-03 00:31:55]

lgtm

[Tom (Use chromium acct), 2017-05-03 03:45:20]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2017-05-03 03:45:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 04:26:36]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493783120516670, "parent_rev":
"b111d54e51d0a7766b477e4c5f1c887f63e8b151", "commit_rev":
"cbe7b7a3a4f5839a11461031904555c4c9eac92a"}

[commit-bot: I haz the power, 2017-05-03 04:27:10]

Description was changed from

==========
Linux native notifications: Implement GetDisplayedNotifications

BUG=676220
R=peter@chromium.org
CC=thestig@chromium.org
==========

to

==========
Linux native notifications: Implement GetDisplayedNotifications

BUG=676220
R=peter@chromium.org
CC=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2848403002
Cr-Commit-Position: refs/heads/master@{#468890}
Committed:
https://chromium.googlesource.com/chromium/src/+/cbe7b7a3a4f5839a114610319045...
==========

[commit-bot: I haz the power, 2017-05-03 04:27:11]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cbe7b7a3a4f5839a114610319045...