Linux native notifications: Implement GetDisplayedNotifications

chrome/browser/notifications/notification_platform_bridge_linux.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/notification_platform_bridge_linux.h"
 
 #include <algorithm>
 
 #include "base/barrier_closure.h"
 #include "base/files/file_util.h"
@@ skipping 436 matching lines @@
     }
     for (NotificationData* data : to_erase)
       notifications_.erase(data);
   }
 
   void GetDisplayedOnTaskRunner(
       const std::string& profile_id,
       bool incognito,
       const GetDisplayedNotificationsCallback& callback) const {
     DCHECK(task_runner_->RunsTasksOnCurrentThread());
-    // TODO(thomasanderson): Implement.
-    PostTaskToUiThread(base::BindOnce(
-        callback, base::Passed(base::MakeUnique<std::set<std::string>>()),
-        false));
+    auto displayed = base::MakeUnique<std::set<std::string>>();
+    for (const auto& notification : notifications_) {
+      if (notification.first->profile_id == profile_id &&
+          notification.first->is_incognito == incognito) {
+        displayed->insert(notification.first->notification_id);
+      }
+    }

[Peter Beverloo, 2017/05/02 13:53:42]

Are we confident that we can rely on the NotificationClosed signal for all
cases? (User dismisses the notification, we dismiss the notification, it
expires, etcetera?) The docs look good, but just to make sure.

These seem like excellent cases to add tests for by the way.

[Tom (Use chromium acct), 2017/05/02 20:59:16]

yes I believe so

+    PostTaskToUiThread(base::BindOnce(callback, std::move(displayed), true));
   }
 
   NotificationData* FindNotificationData(const std::string& notification_id,
                                          const std::string& profile_id,
                                          bool is_incognito) {
     DCHECK(task_runner_->RunsTasksOnCurrentThread());
     for (const auto& pair : notifications_) {
       NotificationData* data = pair.first;
       if (data->notification_id == notification_id &&
           data->profile_id == profile_id &&
@@ skipping 162 matching lines @@
     const std::string& profile_id,
     bool incognito,
     const GetDisplayedNotificationsCallback& callback) const {
   impl_->GetDisplayed(profile_id, incognito, callback);
 }
 
 void NotificationPlatformBridgeLinux::SetReadyCallback(
     NotificationBridgeReadyCallback callback) {
   impl_->SetReadyCallback(std::move(callback));
 }