Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1186)

Issue 2848313004: Mark Number and String as strict functions (Closed)

Created:
3 years, 7 months ago by Jakob Kummerow
Modified:
3 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Mark Number and String as strict functions As required by #sec-built-in-function-objects. They were strict functions before (see e2f1c26982f57411571c4ce41d02f7d56501b208), but that got lost when they were ported to ASM builtins. This makes optimized and non-optimized code agree on the same behavior in regress-105.js. BUG=v8:105, v8:5778, v8:6325 Review-Url: https://codereview.chromium.org/2848313004 Cr-Commit-Position: refs/heads/master@{#45012} Committed: https://chromium.googlesource.com/v8/v8/+/c2f4498f4680fee60606d176aacfaf2c81b66aa0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M src/bootstrapper.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -4 lines 0 comments Download
M test/mjsunit/regress/regress-105.js View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
Jakob Kummerow
PTAL.
3 years, 7 months ago (2017-05-02 08:26:25 UTC) #2
jgruber
lgtm
3 years, 7 months ago (2017-05-02 08:30:02 UTC) #5
Benedikt Meurer
LGTM
3 years, 7 months ago (2017-05-02 08:32:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848313004/1
3 years, 7 months ago (2017-05-02 09:07:39 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 09:09:03 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c2f4498f4680fee60606d176aacfaf2c81b...

Powered by Google App Engine
This is Rietveld 408576698