Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Issue 2848193003: [tests] Fix mjsunit/getters-on-elements (Closed)

Created:
3 years, 7 months ago by Jakob Kummerow
Modified:
3 years, 7 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[tests] Fix mjsunit/getters-on-elements Give the IC one more chance to get itself into a state that's in line with Turbofan's capabilities and the following assertOptimized expectation. BUG=v8:6101, v8:6325 Review-Url: https://codereview.chromium.org/2848193003 Cr-Commit-Position: refs/heads/master@{#45020} Committed: https://chromium.googlesource.com/v8/v8/+/d5401cb225957526607801ff12f904e5e07b14d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M src/runtime/runtime-test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/getters-on-elements.js View 1 chunk +22 lines, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
Jakob Kummerow
Mike, the associated bug is assigned to you. PTAL.
3 years, 7 months ago (2017-05-02 08:38:55 UTC) #2
mvstanton
Wow, thanks for investigating, Jakob! LGTM.
3 years, 7 months ago (2017-05-02 10:39:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848193003/1
3 years, 7 months ago (2017-05-02 10:40:03 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 10:41:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d5401cb225957526607801ff12f904e5e07...

Powered by Google App Engine
This is Rietveld 408576698