[ES6 modules] Fix bad assert in HostResolveImportedModule

[ES6 modules] Fix bad assert in HostResolveImportedModule

Before this CL, ScriptModuleResolverImpl::Resolve wrongly assumed that
resolved module script's instantiation state is always "instantiated".
However, this isn't always the case when instantiating module graph w/
cycles.

This CL removes the CHECK.

Corresponding spec PR: https://github.com/whatwg/html/pull/2603

BUG=594639
, https://github.com/whatwg/html/issues/2596
TEST=external/wpt/html/semantics/scripting-1/the-script-element/module/imports.html shouldn't crash

Review-Url: https://codereview.chromium.org/2848213002
Cr-Commit-Position: refs/heads/master@{#468555}
Committed: https://chromium.googlesource.com/chromium/src/+/f6ff4cd290401c5720e534e52f7ed04544b06e58

[kouhei (in TOK), 2017-05-01 06:52:51]

kouhei@chromium.org changed reviewers:
+ domenic@chromium.org, hiroshige@chromium.org, kinuko@chromium.org,
module-dev@chromium.org, yhirano@chromium.org

[kouhei (in TOK), 2017-05-01 06:53:12]

The CQ bit was checked by kouhei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 06:53:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 09:11:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 09:11:44]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2017-05-01 18:01:45]

lgtm

[kinuko, 2017-05-01 22:27:11]

lgtm

[yhirano, 2017-05-02 02:15:51]

lgtm

[kouhei (in TOK), 2017-05-02 04:17:57]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2017-05-02 04:18:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 04:22:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493698677128130, "parent_rev":
"d087434ab42e298587480260ee4cafbfd002e614", "commit_rev":
"f6ff4cd290401c5720e534e52f7ed04544b06e58"}

[commit-bot: I haz the power, 2017-05-02 04:23:19]

Description was changed from

==========
[ES6 modules] Fix bad assert in HostResolveImportedModule

Before this CL, ScriptModuleResolverImpl::Resolve wrongly assumed that
resolved module script's instantiation state is always "instantiated".
However, this isn't always the case when instantiating module graph w/
cycles.

This CL removes the CHECK.

Corresponding spec PR: https://github.com/whatwg/html/pull/2603

BUG=594639, https://github.com/whatwg/html/issues/2596
TEST=external/wpt/html/semantics/scripting-1/the-script-element/module/imports.html
shouldn't crash
==========

to

==========
[ES6 modules] Fix bad assert in HostResolveImportedModule

Before this CL, ScriptModuleResolverImpl::Resolve wrongly assumed that
resolved module script's instantiation state is always "instantiated".
However, this isn't always the case when instantiating module graph w/
cycles.

This CL removes the CHECK.

Corresponding spec PR: https://github.com/whatwg/html/pull/2603

BUG=594639, https://github.com/whatwg/html/issues/2596
TEST=external/wpt/html/semantics/scripting-1/the-script-element/module/imports.html
shouldn't crash

Review-Url: https://codereview.chromium.org/2848213002
Cr-Commit-Position: refs/heads/master@{#468555}
Committed:
https://chromium.googlesource.com/chromium/src/+/f6ff4cd290401c5720e534e52f7e...
==========

[commit-bot: I haz the power, 2017-05-02 04:23:20]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f6ff4cd290401c5720e534e52f7e...