Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: third_party/WebKit/Source/core/dom/ScriptModuleResolverImpl.cpp

Issue 2848213002: [ES6 modules] Fix bad assert in HostResolveImportedModule (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/ScriptModuleResolverImpl.cpp
diff --git a/third_party/WebKit/Source/core/dom/ScriptModuleResolverImpl.cpp b/third_party/WebKit/Source/core/dom/ScriptModuleResolverImpl.cpp
index b5d90c0b2ac7e1467030fc7b26059ddbe86be4f4..71f082c791e506040a0964aad9f09568469f3a92 100644
--- a/third_party/WebKit/Source/core/dom/ScriptModuleResolverImpl.cpp
+++ b/third_party/WebKit/Source/core/dom/ScriptModuleResolverImpl.cpp
@@ -73,10 +73,7 @@ ScriptModule ScriptModuleResolverImpl::Resolve(
return ScriptModule();
}
- // Step 6. Assert: resolved module script's instantiation state is
- // "instantiated" (and thus its module record is not null).
- CHECK_EQ(module_script->InstantiationState(),
- ModuleInstantiationState::kInstantiated);
+ // Step 6. Assert: resolved module script's module record is not null.
ScriptModule record = module_script->Record();
CHECK(!record.IsNull());
« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698