Revert of Global Resource Coordinator: Basic service internals

Revert of Global Resource Coordinator: Basic service internals (patchset #30 id:560001 of https://codereview.chromium.org/2798713002/ )

Reason for revert:
Breaks android builds: https://bugs.chromium.org/p/chromium/issues/detail?id=716559

Original issue's description:
> Global Resource Coordinator: Basic service internals
> 
> This adds the basic internals of the GRC; CoordinationUnits which can form a DAG, receive events, and send back updated resource usage policies.
> 
> A full prototype of GRC usage can be seen here: https://codereview.chromium.org/2710823003
> 
> Service architecture doc: https://docs.google.com/document/d/1qec4DNDM2pLLIFfCBtnNQTxlNXQzjml69yC8SGU9bzI/edit#
> 
> GRC parent doc (internal only): https://docs.google.com/document/d/1dx4KDbDFvP-GWwwrSPg8Gxx4kboIoPi8kDKTSXoTbC4/edit#heading=h.td4yhfm12fe3
> 
> R=primiano@chromium.org,skyostil@chromium.org,fmeawad@chromium.org,rockot@chromium.org
> BUG=691886
> 
> Review-Url: https://codereview.chromium.org/2798713002
> Cr-Commit-Position: refs/heads/master@{#468002}
> Committed: https://chromium.googlesource.com/chromium/src/+/de0f39d2a625433e60b5e22e1d2d3803f3d219e5

TBR=chrisha@chromium.org,dcheng@chromium.org,fmeawad@chromium.org,jam@chromium.org,nasko@chromium.org,primiano@chromium.org,rockot@chromium.org,skyostil@chromium.org,oysteine@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=691886

[Khushal, 2017-04-28 19:50:38]

The CQ bit was checked by khushalsagar@chromium.org

[Khushal, 2017-04-28 19:50:39]

Created Revert of Global Resource Coordinator: Basic service internals

[commit-bot: I haz the power, 2017-04-28 19:52:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 19:53:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 19:53:27]

Failed to apply patch for services/resource_coordinator/DEPS:
While running git rm services/resource_coordinator/DEPS;
  fatal: pathspec 'services/resource_coordinator/DEPS' did not match any files

Patch:  D    services/resource_coordinator/DEPS
Index: services/resource_coordinator/DEPS
diff --git a/services/resource_coordinator/DEPS
b/services/resource_coordinator/DEPS
deleted file mode 100644
index
aa579c4766f331faf96fb2205ddecee110e35b04..0000000000000000000000000000000000000000
--- a/services/resource_coordinator/DEPS
+++ /dev/null
@@ -1,3 +0,0 @@
-include_rules = [
-  "+third_party/smhasher",
-]

[Ken Rockot(use gerrit already), 2017-04-28 19:56:20]

It's already been reverted for other reasons.

On Fri, Apr 28, 2017 at 12:53 PM, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Failed to apply patch for services/resource_coordinator/DEPS:
> While running git rm services/resource_coordinator/DEPS;
> fatal: pathspec 'services/resource_coordinator/DEPS' did not match any
> files
>
> Patch: D services/resource_coordinator/DEPS
> Index: services/resource_coordinator/DEPS
> diff --git a/services/resource_coordinator/DEPS
> b/services/resource_coordinator/DEPS
> deleted file mode 100644
> index
> aa579c4766f331faf96fb2205ddecee110e35b04..000000000000000000000000000000
> 0000000000
> --- a/services/resource_coordinator/DEPS
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -include_rules = [
> - "+third_party/smhasher",
> -]
>
>
> https://codereview.chromium.org/2848053002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sky, 2017-04-28 19:56:35]

This was reverted here: https://codereview.chromium.org/2851813002/

On Fri, Apr 28, 2017 at 12:50 PM, <khushalsagar@chromium.org> wrote:

> Reviewers: chrisha, dcheng (OOO through May 2), fmeawad, jam, nasko,
> Primiano Tucci, Ken Rockot, Sami, oystein
> CL: https://codereview.chromium.org/2848053002/
>
> Message:
> Created Revert of Global Resource Coordinator: Basic service internals
>
> Description:
> Revert of Global Resource Coordinator: Basic service internals (patchset
> #30
> id:560001 of https://codereview.chromium.org/2798713002/ )
>
> Reason for revert:
> Breaks android builds:
> https://bugs.chromium.org/p/chromium/issues/detail?id=716559
>
> Original issue's description:
> > Global Resource Coordinator: Basic service internals
> >
> > This adds the basic internals of the GRC; CoordinationUnits which can
> form a
> DAG, receive events, and send back updated resource usage policies.
> >
> > A full prototype of GRC usage can be seen here:
> https://codereview.chromium.org/2710823003
> >
> > Service architecture doc:
> https://docs.google.com/document/d/1qec4DNDM2pLLIFfCBtnNQTxlNXQzj
> ml69yC8SGU9bzI/edit#
>
<https://docs.google.com/document/d/1qec4DNDM2pLLIFfCBtnNQTxlNXQzjml69yC8SGU9b...>
> >
> > GRC parent doc (internal only):
> https://docs.google.com/document/d/1dx4KDbDFvP-
> GWwwrSPg8Gxx4kboIoPi8kDKTSXoTbC4/edit#heading=h.td4yhfm12fe3
> >
> >
> R=primiano@chromium.org,skyostil@chromium.org,fmeawad@
> chromium.org,rockot@chromium.org
> > BUG=691886
> >
> > Review-Url: https://codereview.chromium.org/2798713002
> > Cr-Commit-Position: refs/heads/master@{#468002}
> > Committed:
> https://chromium.googlesource.com/chromium/src/+/
> de0f39d2a625433e60b5e22e1d2d3803f3d219e5
>
> TBR=chrisha@chromium.org,dcheng@chromium.org,fmeawad@
> chromium.org,jam@chromium.org,nasko@chromium.org,primiano@
> chromium.org,rockot@chromium.org,skyostil@chromium.org,
> oysteine@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=691886
>
> Affected files (+51, -1344 lines):
> M services/resource_coordinator/BUILD.gn
> D services/resource_coordinator/DEPS
> D services/resource_coordinator/coordination_unit/coordination_unit_impl.h
> D services/resource_coordinator/coordination_unit/
> coordination_unit_impl.cc
> D services/resource_coordinator/coordination_unit/coordination_unit_impl_
> unittest.cc
> D services/resource_coordinator/coordination_unit/
> coordination_unit_provider_impl.h
> D services/resource_coordinator/coordination_unit/
> coordination_unit_provider_impl.cc
> D services/resource_coordinator/manifest.json
> M services/resource_coordinator/public/cpp/BUILD.gn
> D services/resource_coordinator/public/cpp/OWNERS
> D services/resource_coordinator/public/cpp/coordination_unit.typemap
> D services/resource_coordinator/public/cpp/coordination_unit_id.h
> D services/resource_coordinator/public/cpp/coordination_unit_id.cc
> D services/resource_coordinator/public/cpp/coordination_unit_
> struct_traits.h
> D services/resource_coordinator/public/cpp/coordination_unit_
> struct_traits.cc
> D services/resource_coordinator/public/cpp/coordination_unit_types.h
> A services/resource_coordinator/public/cpp/memory/memory_export.h
> M services/resource_coordinator/public/cpp/memory/memory_
> instrumentation_struct_traits.h
> M services/resource_coordinator/public/cpp/memory/process_
> local_dump_manager_impl.h
> D services/resource_coordinator/public/cpp/resource_coordinator_export.h
> D services/resource_coordinator/public/cpp/resource_
> coordinator_interface.h
> D services/resource_coordinator/public/cpp/resource_
> coordinator_interface.cc
> M services/resource_coordinator/public/cpp/typemaps.gni
> M services/resource_coordinator/public/interfaces/BUILD.gn
> D services/resource_coordinator/public/interfaces/coordination_unit.mojom
> D services/resource_coordinator/public/interfaces/
> coordination_unit_provider.mojom
> D services/resource_coordinator/public/interfaces/events.mojom
> D services/resource_coordinator/public/interfaces/service_constants.mojom
> D services/resource_coordinator/resource_coordinator_service.h
> D services/resource_coordinator/resource_coordinator_service.cc
> D services/resource_coordinator/resource_coordinator_service_unittest.cc
> D services/resource_coordinator/service_main.cc
> D services/resource_coordinator/unittest_manifest.json
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Khushal, 2017-04-28 20:00:41]

On 2017/04/28 19:56:35, sky wrote:
> This was reverted here: https://codereview.chromium.org/2851813002/

Oh great. Thanks!

> 
> On Fri, Apr 28, 2017 at 12:50 PM, <mailto:khushalsagar@chromium.org> wrote:
> 
> > Reviewers: chrisha, dcheng (OOO through May 2), fmeawad, jam, nasko,
> > Primiano Tucci, Ken Rockot, Sami, oystein
> > CL: https://codereview.chromium.org/2848053002/
> >
> > Message:
> > Created Revert of Global Resource Coordinator: Basic service internals
> >
> > Description:
> > Revert of Global Resource Coordinator: Basic service internals (patchset
> > #30
> > id:560001 of https://codereview.chromium.org/2798713002/ )
> >
> > Reason for revert:
> > Breaks android builds:
> > https://bugs.chromium.org/p/chromium/issues/detail?id=716559
> >
> > Original issue's description:
> > > Global Resource Coordinator: Basic service internals
> > >
> > > This adds the basic internals of the GRC; CoordinationUnits which can
> > form a
> > DAG, receive events, and send back updated resource usage policies.
> > >
> > > A full prototype of GRC usage can be seen here:
> > https://codereview.chromium.org/2710823003
> > >
> > > Service architecture doc:
> > https://docs.google.com/document/d/1qec4DNDM2pLLIFfCBtnNQTxlNXQzj
> > ml69yC8SGU9bzI/edit#
> >
>
<https://docs.google.com/document/d/1qec4DNDM2pLLIFfCBtnNQTxlNXQzjml69yC8SGU9b...>
> > >
> > > GRC parent doc (internal only):
> > https://docs.google.com/document/d/1dx4KDbDFvP-
> > GWwwrSPg8Gxx4kboIoPi8kDKTSXoTbC4/edit#heading=h.td4yhfm12fe3
> > >
> > >
> > mailto:R=primiano@chromium.org,skyostil@chromium.org,fmeawad@
> > mailto:chromium.org,rockot@chromium.org
> > > BUG=691886
> > >
> > > Review-Url: https://codereview.chromium.org/2798713002
> > > Cr-Commit-Position: refs/heads/master@{#468002}
> > > Committed:
> > https://chromium.googlesource.com/chromium/src/+/
> > de0f39d2a625433e60b5e22e1d2d3803f3d219e5
> >
> > mailto:TBR=chrisha@chromium.org,dcheng@chromium.org,fmeawad@
> > mailto:chromium.org,jam@chromium.org,nasko@chromium.org,primiano@
> > mailto:chromium.org,rockot@chromium.org,skyostil@chromium.org,
> > mailto:oysteine@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=691886
> >
> > Affected files (+51, -1344 lines):
> > M services/resource_coordinator/BUILD.gn
> > D services/resource_coordinator/DEPS
> > D services/resource_coordinator/coordination_unit/coordination_unit_impl.h
> > D services/resource_coordinator/coordination_unit/
> > coordination_unit_impl.cc
> > D services/resource_coordinator/coordination_unit/coordination_unit_impl_
> > unittest.cc
> > D services/resource_coordinator/coordination_unit/
> > coordination_unit_provider_impl.h
> > D services/resource_coordinator/coordination_unit/
> > coordination_unit_provider_impl.cc
> > D services/resource_coordinator/manifest.json
> > M services/resource_coordinator/public/cpp/BUILD.gn
> > D services/resource_coordinator/public/cpp/OWNERS
> > D services/resource_coordinator/public/cpp/coordination_unit.typemap
> > D services/resource_coordinator/public/cpp/coordination_unit_id.h
> > D services/resource_coordinator/public/cpp/coordination_unit_id.cc
> > D services/resource_coordinator/public/cpp/coordination_unit_
> > struct_traits.h
> > D services/resource_coordinator/public/cpp/coordination_unit_
> > struct_traits.cc
> > D services/resource_coordinator/public/cpp/coordination_unit_types.h
> > A services/resource_coordinator/public/cpp/memory/memory_export.h
> > M services/resource_coordinator/public/cpp/memory/memory_
> > instrumentation_struct_traits.h
> > M services/resource_coordinator/public/cpp/memory/process_
> > local_dump_manager_impl.h
> > D services/resource_coordinator/public/cpp/resource_coordinator_export.h
> > D services/resource_coordinator/public/cpp/resource_
> > coordinator_interface.h
> > D services/resource_coordinator/public/cpp/resource_
> > coordinator_interface.cc
> > M services/resource_coordinator/public/cpp/typemaps.gni
> > M services/resource_coordinator/public/interfaces/BUILD.gn
> > D services/resource_coordinator/public/interfaces/coordination_unit.mojom
> > D services/resource_coordinator/public/interfaces/
> > coordination_unit_provider.mojom
> > D services/resource_coordinator/public/interfaces/events.mojom
> > D services/resource_coordinator/public/interfaces/service_constants.mojom
> > D services/resource_coordinator/resource_coordinator_service.h
> > D services/resource_coordinator/resource_coordinator_service.cc
> > D services/resource_coordinator/resource_coordinator_service_unittest.cc
> > D services/resource_coordinator/service_main.cc
> > D services/resource_coordinator/unittest_manifest.json
> >
> >
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[Khushal, 2017-04-28 23:22:33]

Description was changed from

==========
Revert of Global Resource Coordinator: Basic service internals (patchset #30
id:560001 of https://codereview.chromium.org/2798713002/ )

Reason for revert:
Breaks android builds:
https://bugs.chromium.org/p/chromium/issues/detail?id=716559

Original issue's description:
> Global Resource Coordinator: Basic service internals
> 
> This adds the basic internals of the GRC; CoordinationUnits which can form a
DAG, receive events, and send back updated resource usage policies.
> 
> A full prototype of GRC usage can be seen here:
https://codereview.chromium.org/2710823003
> 
> Service architecture doc:
https://docs.google.com/document/d/1qec4DNDM2pLLIFfCBtnNQTxlNXQzjml69yC8SGU9b...
> 
> GRC parent doc (internal only):
https://docs.google.com/document/d/1dx4KDbDFvP-GWwwrSPg8Gxx4kboIoPi8kDKTSXoTb...
> 
>
R=primiano@chromium.org,skyostil@chromium.org,fmeawad@chromium.org,rockot@chr...
> BUG=691886
> 
> Review-Url: https://codereview.chromium.org/2798713002
> Cr-Commit-Position: refs/heads/master@{#468002}
> Committed:
https://chromium.googlesource.com/chromium/src/+/de0f39d2a625433e60b5e22e1d2d...

TBR=chrisha@chromium.org,dcheng@chromium.org,fmeawad@chromium.org,jam@chromiu...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=691886
==========

to

==========
Revert of Global Resource Coordinator: Basic service internals (patchset #30
id:560001 of https://codereview.chromium.org/2798713002/ )

Reason for revert:
Breaks android builds:
https://bugs.chromium.org/p/chromium/issues/detail?id=716559

Original issue's description:
> Global Resource Coordinator: Basic service internals
> 
> This adds the basic internals of the GRC; CoordinationUnits which can form a
DAG, receive events, and send back updated resource usage policies.
> 
> A full prototype of GRC usage can be seen here:
https://codereview.chromium.org/2710823003
> 
> Service architecture doc:
https://docs.google.com/document/d/1qec4DNDM2pLLIFfCBtnNQTxlNXQzjml69yC8SGU9b...
> 
> GRC parent doc (internal only):
https://docs.google.com/document/d/1dx4KDbDFvP-GWwwrSPg8Gxx4kboIoPi8kDKTSXoTb...
> 
>
R=primiano@chromium.org,skyostil@chromium.org,fmeawad@chromium.org,rockot@chr...
> BUG=691886
> 
> Review-Url: https://codereview.chromium.org/2798713002
> Cr-Commit-Position: refs/heads/master@{#468002}
> Committed:
https://chromium.googlesource.com/chromium/src/+/de0f39d2a625433e60b5e22e1d2d...

TBR=chrisha@chromium.org,dcheng@chromium.org,fmeawad@chromium.org,jam@chromiu...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=691886
==========