Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 2851813002: Revert of Global Resource Coordinator: Basic service internals (Closed)

Created:
3 years, 7 months ago by sky
Modified:
3 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, chrome-grc-reviews_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Global Resource Coordinator: Basic service internals (patchset #30 id:560001 of https://codereview.chromium.org/2798713002/ ) Reason for revert: Reverting as CoordinationUnitImplTest.CyclicGraphUnits is crashing on windows dbg. The output isn't very helpful: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWin7_Tests__dbg__1_%2F59514%2F%2B%2Frecipes%2Fsteps%2Fservice_unittests%2F0%2Fstdout RUN ] CoordinationUnitImplTest.CyclicGraphUnits [114/116] CoordinationUnitImplTest.CyclicGraphUnits (CRASHED) [115/116] CoordinatorImplTest.NoProcessLocalManagers (1 ms) [116/116] CoordinatorImplTest.SeveralProcessLocalManagers (4 ms) Retrying 1 test (retry #1) [ RUN ] CoordinationUnitImplTest.CyclicGraphUnits [117/117] CoordinationUnitImplTest.CyclicGraphUnits (CRASHED) Retrying 1 test (retry #2) [ RUN ] CoordinationUnitImplTest.CyclicGraphUnits [118/118] CoordinationUnitImplTest.CyclicGraphUnits (CRASHED) Retrying 1 test (retry #3) [ RUN ] CoordinationUnitImplTest.CyclicGraphUnits [119/119] CoordinationUnitImplTest.CyclicGraphUnits (CRASHED) Original issue's description: > Global Resource Coordinator: Basic service internals > > This adds the basic internals of the GRC; CoordinationUnits which can form a DAG, receive events, and send back updated resource usage policies. > > A full prototype of GRC usage can be seen here: https://codereview.chromium.org/2710823003 > > Service architecture doc: https://docs.google.com/document/d/1qec4DNDM2pLLIFfCBtnNQTxlNXQzjml69yC8SGU9bzI/edit# > > GRC parent doc (internal only): https://docs.google.com/document/d/1dx4KDbDFvP-GWwwrSPg8Gxx4kboIoPi8kDKTSXoTbC4/edit#heading=h.td4yhfm12fe3 > > R=primiano@chromium.org,skyostil@chromium.org,fmeawad@chromium.org,rockot@chromium.org > BUG=691886 > > Review-Url: https://codereview.chromium.org/2798713002 > Cr-Commit-Position: refs/heads/master@{#468002} > Committed: https://chromium.googlesource.com/chromium/src/+/de0f39d2a625433e60b5e22e1d2d3803f3d219e5 TBR=chrisha@chromium.org,dcheng@chromium.org,fmeawad@chromium.org,jam@chromium.org,nasko@chromium.org,primiano@chromium.org,rockot@chromium.org,skyostil@chromium.org,oysteine@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=691886 Review-Url: https://codereview.chromium.org/2851813002 Cr-Commit-Position: refs/heads/master@{#468061} Committed: https://chromium.googlesource.com/chromium/src/+/1d19b802b839f71f5d077fe3edb92e7902f4db52

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -1344 lines) Patch
M services/resource_coordinator/BUILD.gn View 3 chunks +1 line, -61 lines 0 comments Download
D services/resource_coordinator/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D services/resource_coordinator/coordination_unit/coordination_unit_impl.h View 1 chunk +0 lines, -72 lines 0 comments Download
D services/resource_coordinator/coordination_unit/coordination_unit_impl.cc View 1 chunk +0 lines, -220 lines 0 comments Download
D services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest.cc View 1 chunk +0 lines, -196 lines 0 comments Download
D services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.h View 1 chunk +0 lines, -45 lines 0 comments Download
D services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D services/resource_coordinator/manifest.json View 1 chunk +0 lines, -15 lines 0 comments Download
M services/resource_coordinator/public/cpp/BUILD.gn View 3 chunks +2 lines, -10 lines 0 comments Download
D services/resource_coordinator/public/cpp/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D services/resource_coordinator/public/cpp/coordination_unit.typemap View 1 chunk +0 lines, -19 lines 0 comments Download
D services/resource_coordinator/public/cpp/coordination_unit_id.h View 1 chunk +0 lines, -44 lines 0 comments Download
D services/resource_coordinator/public/cpp/coordination_unit_id.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D services/resource_coordinator/public/cpp/coordination_unit_struct_traits.h View 1 chunk +0 lines, -39 lines 0 comments Download
D services/resource_coordinator/public/cpp/coordination_unit_struct_traits.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D services/resource_coordinator/public/cpp/coordination_unit_types.h View 1 chunk +0 lines, -24 lines 0 comments Download
A services/resource_coordinator/public/cpp/memory/memory_export.h View 1 chunk +32 lines, -0 lines 0 comments Download
M services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.h View 6 chunks +7 lines, -7 lines 0 comments Download
M services/resource_coordinator/public/cpp/memory/process_local_dump_manager_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
D services/resource_coordinator/public/cpp/resource_coordinator_export.h View 1 chunk +0 lines, -30 lines 0 comments Download
D services/resource_coordinator/public/cpp/resource_coordinator_interface.h View 1 chunk +0 lines, -56 lines 0 comments Download
D services/resource_coordinator/public/cpp/resource_coordinator_interface.cc View 1 chunk +0 lines, -80 lines 0 comments Download
M services/resource_coordinator/public/cpp/typemaps.gni View 1 chunk +1 line, -4 lines 0 comments Download
M services/resource_coordinator/public/interfaces/BUILD.gn View 2 chunks +5 lines, -7 lines 0 comments Download
D services/resource_coordinator/public/interfaces/coordination_unit.mojom View 1 chunk +0 lines, -45 lines 0 comments Download
D services/resource_coordinator/public/interfaces/coordination_unit_provider.mojom View 1 chunk +0 lines, -11 lines 0 comments Download
D services/resource_coordinator/public/interfaces/events.mojom View 1 chunk +0 lines, -19 lines 0 comments Download
D services/resource_coordinator/public/interfaces/service_constants.mojom View 1 chunk +0 lines, -7 lines 0 comments Download
D services/resource_coordinator/resource_coordinator_service.h View 1 chunk +0 lines, -47 lines 0 comments Download
D services/resource_coordinator/resource_coordinator_service.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D services/resource_coordinator/resource_coordinator_service_unittest.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D services/resource_coordinator/service_main.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D services/resource_coordinator/unittest_manifest.json View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sky
Created Revert of Global Resource Coordinator: Basic service internals
3 years, 7 months ago (2017-04-28 18:13:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851813002/1
3 years, 7 months ago (2017-04-28 18:14:47 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 18:15:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1d19b802b839f71f5d077fe3edb9...

Powered by Google App Engine
This is Rietveld 408576698