Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 2847923004: Android: ResourceExtractor.java: Extract files atomically (Closed)

Created:
3 years, 7 months ago by agrieve
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Android: ResourceExtractor.java: Extract files atomically Extracts to a temporary and then moves them into place. The goal is to avoid half-extracted files (e.g. upon crash or power failure). The extractor does not validate them on start-up. BUG=691719 Review-Url: https://codereview.chromium.org/2828583002 Cr-Commit-Position: refs/heads/master@{#465592} (cherry picked from commit 4c8239ac8c3c3dd581963aeb6e5dcb2e381d0b58) Review-Url: https://codereview.chromium.org/2847923004 . Cr-Commit-Position: refs/branch-heads/3071@{#293} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/bf64cf69693a7a7611f1f484ad93315bf4b34d2c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M base/android/java/src/org/chromium/base/ResourceExtractor.java View 4 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
agrieve
3 years, 7 months ago (2017-04-28 15:27:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bf64cf69693a7a7611f1f484ad93315bf4b34d2c.

Powered by Google App Engine
This is Rietveld 408576698