Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2828583002: Android: ResourceExtractor.java: Extract files atomically (Closed)

Created:
3 years, 8 months ago by agrieve
Modified:
3 years, 8 months ago
Reviewers:
estevenson
CC:
chromium-reviews, danakj+watch_chromium.org, agrieve+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: ResourceExtractor.java: Extract files atomically Extracts to a temporary and then moves them into place. The goal is to avoid half-extracted files (e.g. upon crash or power failure). The extractor does not validate them on start-up. BUG=691719 Review-Url: https://codereview.chromium.org/2828583002 Cr-Commit-Position: refs/heads/master@{#465592} Committed: https://chromium.googlesource.com/chromium/src/+/4c8239ac8c3c3dd581963aeb6e5dcb2e381d0b58

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M base/android/java/src/org/chromium/base/ResourceExtractor.java View 4 chunks +11 lines, -11 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (10 generated)
estevenson
lgtm. Maybe update the commit message to include the purpose, which is to avoid half-written ...
3 years, 8 months ago (2017-04-19 14:12:30 UTC) #7
agrieve
On 2017/04/19 14:12:30, estevenson wrote: > lgtm. > > Maybe update the commit message to ...
3 years, 8 months ago (2017-04-19 14:15:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828583002/1
3 years, 8 months ago (2017-04-19 14:15:44 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 14:20:02 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4c8239ac8c3c3dd581963aeb6e5d...

Powered by Google App Engine
This is Rietveld 408576698