PDF pinch-zoom: preventDefault on 2 finger touchmoves, not touchstarts.

PDF pinch-zoom: preventDefault on 2 finger touchmoves, not touchstarts.

Currently, to prevent native pinch-zoom from interfering with how we
handle pinch-zoom in the PDF viewer, we preventDefault the 2 finger
touchstart that corresponds to the gesture pinch start. However, this
also prevents 2 finger tap gestures.

We now preventDefault the 2 finger touchmoves so that native pinch-zoom
is still prevented, while 2 finger tap gestures are not affected.

BUG=716123
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2847893005
Cr-Commit-Position: refs/heads/master@{#468986}
Committed: https://chromium.googlesource.com/chromium/src/+/fee63e1624e66315c67ac29c9d62e950944e012c

[Kevin McNee, 2017-04-28 20:57:36]

Description was changed from

==========
PDF pinch-zoom: preventDefault on 2 finger touchmoves, not touchstarts.

Currently, to prevent native pinch-zoom from interfering with how we
handle pinch-zoom in the PDF viewer, we preventDefault the 2 finger
touchstart that corresponds to the gesture pinch start. However, this
also prevents 2 finger tap gestures.

We now preventDefault the 2 finger touchmoves so that native pinch-zoom
is still prevented, while 2 finger tap gestures are not affected.

BUG=716123
==========

to

==========
PDF pinch-zoom: preventDefault on 2 finger touchmoves, not touchstarts.

Currently, to prevent native pinch-zoom from interfering with how we
handle pinch-zoom in the PDF viewer, we preventDefault the 2 finger
touchstart that corresponds to the gesture pinch start. However, this
also prevents 2 finger tap gestures.

We now preventDefault the 2 finger touchmoves so that native pinch-zoom
is still prevented, while 2 finger tap gestures are not affected.

BUG=716123
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Kevin McNee, 2017-04-28 20:59:48]

The CQ bit was checked by mcnee@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 21:00:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 22:22:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 22:22:13]

Dry run: This issue passed the CQ dry run.

[Kevin McNee, 2017-05-02 20:08:44]

Description was changed from

==========
PDF pinch-zoom: preventDefault on 2 finger touchmoves, not touchstarts.

Currently, to prevent native pinch-zoom from interfering with how we
handle pinch-zoom in the PDF viewer, we preventDefault the 2 finger
touchstart that corresponds to the gesture pinch start. However, this
also prevents 2 finger tap gestures.

We now preventDefault the 2 finger touchmoves so that native pinch-zoom
is still prevented, while 2 finger tap gestures are not affected.

BUG=716123
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
PDF pinch-zoom: preventDefault on 2 finger touchmoves, not touchstarts.

Currently, to prevent native pinch-zoom from interfering with how we
handle pinch-zoom in the PDF viewer, we preventDefault the 2 finger
touchstart that corresponds to the gesture pinch start. However, this
also prevents 2 finger tap gestures.

We now preventDefault the 2 finger touchmoves so that native pinch-zoom
is still prevented, while 2 finger tap gestures are not affected.

BUG=716123
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Kevin McNee, 2017-05-02 20:08:45]

mcnee@chromium.org changed reviewers:
+ raymes@chromium.org

[Kevin McNee, 2017-05-02 20:20:13]

Hello, raymes. This is the CL that dsinclair's long press CL
(https://codereview.chromium.org/2855953003/) depends on. bokan typically looks
at these PDF pinch zooming CLs first, but he's OOO until the 9th. I thought I'd
send this to you now, but if you want to defer, that's fine.

[raymes, 2017-05-02 22:05:51]

lgtm

In the future please send reviews to someone else working on PDF for a
preliminary review, e.g. dsinclair (I'd like to transition away from being a PDF
owner).

[Kevin McNee, 2017-05-03 13:39:13]

The CQ bit was checked by mcnee@chromium.org

[commit-bot: I haz the power, 2017-05-03 13:39:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2017-05-03 14:49:43]

dsinclair@chromium.org changed reviewers:
+ dsinclair@chromium.org

[dsinclair, 2017-05-03 14:49:44]

lgtm

[commit-bot: I haz the power, 2017-05-03 15:51:25]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493818753978080, "parent_rev":
"692751dc80943ee7094ee1027d9cdc8c8f3d5170", "commit_rev":
"fee63e1624e66315c67ac29c9d62e950944e012c"}

[commit-bot: I haz the power, 2017-05-03 15:51:33]

Description was changed from

==========
PDF pinch-zoom: preventDefault on 2 finger touchmoves, not touchstarts.

Currently, to prevent native pinch-zoom from interfering with how we
handle pinch-zoom in the PDF viewer, we preventDefault the 2 finger
touchstart that corresponds to the gesture pinch start. However, this
also prevents 2 finger tap gestures.

We now preventDefault the 2 finger touchmoves so that native pinch-zoom
is still prevented, while 2 finger tap gestures are not affected.

BUG=716123
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
PDF pinch-zoom: preventDefault on 2 finger touchmoves, not touchstarts.

Currently, to prevent native pinch-zoom from interfering with how we
handle pinch-zoom in the PDF viewer, we preventDefault the 2 finger
touchstart that corresponds to the gesture pinch start. However, this
also prevents 2 finger tap gestures.

We now preventDefault the 2 finger touchmoves so that native pinch-zoom
is still prevented, while 2 finger tap gestures are not affected.

BUG=716123
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2847893005
Cr-Commit-Position: refs/heads/master@{#468986}
Committed:
https://chromium.googlesource.com/chromium/src/+/fee63e1624e66315c67ac29c9d62...
==========

[commit-bot: I haz the power, 2017-05-03 15:51:34]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fee63e1624e66315c67ac29c9d62...