Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3353)

Unified Diff: chrome/test/data/pdf/gesture_detector_test.js

Issue 2847893005: PDF pinch-zoom: preventDefault on 2 finger touchmoves, not touchstarts. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/pdf/gesture_detector.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/pdf/gesture_detector_test.js
diff --git a/chrome/test/data/pdf/gesture_detector_test.js b/chrome/test/data/pdf/gesture_detector_test.js
index b238294f46104158a05031333ba6336b12edb937..c038e28f09fab2afe977a4995df1c1a213028554 100644
--- a/chrome/test/data/pdf/gesture_detector_test.js
+++ b/chrome/test/data/pdf/gesture_detector_test.js
@@ -182,24 +182,34 @@ chrome.test.runTests(function() {
let gestureDetector = new GestureDetector(stubElement);
let pinchListener = new PinchListener(gestureDetector);
- // Ensure that the touchstart listener is not passive, otherwise the
+ // Ensure that the touchmove listener is not passive, otherwise the
// call to preventDefault will be ignored. Since listeners could default
// to being passive, we must set the value explicitly
// (see crbug.com/675730).
- for (let l of stubElement.listeners.get('touchstart')) {
+ for (let l of stubElement.listeners.get('touchmove')) {
let options = stubElement.listenerOptions.get(l);
chrome.test.assertTrue(!!options &&
typeof(options.passive) == 'boolean');
chrome.test.assertFalse(options.passive);
}
+ // We should not preventDefault the touchstart for 2 fingers, since this
+ // could just be a 2 finger tap.
let pinchStartEvent = new MockTouchEvent('touchstart', [
{clientX: 0, clientY: 0},
{clientX: 0, clientY: 2}
]);
stubElement.sendEvent(pinchStartEvent);
chrome.test.assertEq('pinchstart', pinchListener.lastEvent.type);
- chrome.test.assertTrue(pinchStartEvent.defaultPrevented);
+ chrome.test.assertFalse(pinchStartEvent.defaultPrevented);
+
+ let pinchUpdateEvent = new MockTouchEvent('touchmove', [
+ {clientX: 0, clientY: 0},
+ {clientX: 0, clientY: 4}
+ ]);
+ stubElement.sendEvent(pinchUpdateEvent);
+ chrome.test.assertEq('pinchupdate', pinchListener.lastEvent.type);
+ chrome.test.assertTrue(pinchUpdateEvent.defaultPrevented);
chrome.test.succeed();
}
« no previous file with comments | « chrome/browser/resources/pdf/gesture_detector.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698