Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2847893002: fix #27258, don't allow dynamic set of a final field (Closed)

Created:
3 years, 7 months ago by Jennifer Messerly
Modified:
3 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix #27258, don't allow dynamic set of a final field R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/eeb0e1d2aef76d38d18171676e69f73dfac0cfa2

Patch Set 1 #

Patch Set 2 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -148 lines) Patch
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View 1 Binary file 0 comments Download
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 1 7 chunks +47 lines, -41 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/BenchmarkBase.js View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/test/codegen_expected/closure.js View 1 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/sunflower/sunflower.js View 1 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart View 1 4 chunks +48 lines, -40 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart View 1 3 chunks +13 lines, -38 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart View 1 3 chunks +12 lines, -19 lines 0 comments Download
A tests/language_strong/dynamic_set_test.dart View 1 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
3 years, 7 months ago (2017-04-27 22:54:33 UTC) #2
vsm
lgtm
3 years, 7 months ago (2017-05-01 20:52:41 UTC) #3
Jennifer Messerly
3 years, 7 months ago (2017-05-01 22:36:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:10001) manually as
eeb0e1d2aef76d38d18171676e69f73dfac0cfa2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698