Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: pkg/dev_compiler/test/codegen_expected/BenchmarkBase.js

Issue 2847893002: fix #27258, don't allow dynamic set of a final field (Closed)
Patch Set: format Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dev_compiler/test/codegen_expected/BenchmarkBase.js
diff --git a/pkg/dev_compiler/test/codegen_expected/BenchmarkBase.js b/pkg/dev_compiler/test/codegen_expected/BenchmarkBase.js
index 20b9dceb62a5e7d88921d63f39def68d8957cef8..cca6c6a3ad3a20151a307d72732a8a6ec60606b3 100644
--- a/pkg/dev_compiler/test/codegen_expected/BenchmarkBase.js
+++ b/pkg/dev_compiler/test/codegen_expected/BenchmarkBase.js
@@ -83,7 +83,7 @@ define(['dart_sdk'], function(dart_sdk) {
};
const name$ = Symbol("BenchmarkBase.name");
dart.setSignature(BenchmarkBase$.BenchmarkBase, {
- fields: () => ({name: core.String}),
+ fields: () => ({name: dart.finalFieldType(core.String)}),
methods: () => ({
run: dart.definiteFunctionType(dart.void, []),
warmup: dart.definiteFunctionType(dart.void, []),
« no previous file with comments | « pkg/dev_compiler/lib/src/compiler/code_generator.dart ('k') | pkg/dev_compiler/test/codegen_expected/closure.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698